Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does VeSyncSuperior6000S support automatic stop? #302

Open
iprak opened this issue Feb 15, 2025 · 3 comments
Open

Does VeSyncSuperior6000S support automatic stop? #302

iprak opened this issue Feb 15, 2025 · 3 comments

Comments

@iprak
Copy link
Contributor

iprak commented Feb 15, 2025

The automatic_stop control methods on VeSyncSuperior6000S are setting humidity. There is also no property indicating the automatic-off status. This makes me wonder if VeSyncSuperior6000S actually supports this feature and if the incorrect methods should be removed?

The automatic off I am referring to is the one when the humidity is within 5% of the target.

Image

    def automatic_stop_on(self) -> bool:
        """Set humidity mode to auto."""
        return self.set_humidity_mode('auto')

    def automatic_stop_off(self) -> bool:
        """Set humidity mode to manual."""
        return self.set_humidity_mode('manual')
@webdjoe
Copy link
Owner

webdjoe commented Feb 15, 2025

Image

It should support both "humidity" and "auto" mode. I don't know why the function was named automatic stop, it should just be auto_mode_on and auto_mode_off

Auto mode sets fan and mist level based on distance from target humidity. Humidity mode runs until the target humidity is reached.

Image

@iprak
Copy link
Contributor Author

iprak commented Feb 15, 2025

Ok, that makes sense. I can put in a PR for that.

@webdjoe
Copy link
Owner

webdjoe commented Feb 15, 2025

Hold off on the PR's for now, let me get the async PR finished. Already did the library, working on tests now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants