Skip to content

Commit 1940b9a

Browse files
committed
Merge pull request #429 from hwshim/master
[BUGFIX] Global menu for workspace and editors
2 parents 23d8e6d + b2d0ad3 commit 1940b9a

File tree

3 files changed

+10
-7
lines changed

3 files changed

+10
-7
lines changed

apps/ide/src/plugins/webida.editor.code-editor/CodeEditorViewer.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1480,10 +1480,10 @@ define([
14801480
deferred.resolve(items);
14811481
});
14821482
} else {
1483-
deferred.resolve(items);
1483+
deferred.resolve(items);
14841484
}
14851485
} else {
1486-
deferred.resolve(items);
1486+
deferred.resolve(items);
14871487
}
14881488
},
14891489

apps/ide/src/plugins/webida.editor.text-editor/TextEditorViewer.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1477,7 +1477,7 @@ define([
14771477
}
14781478
},
14791479

1480-
getMenuItemsUnderEdit: function(items, menuItems) {
1480+
getMenuItemsUnderEdit: function(items, menuItems, deferred) {
14811481
var editor = this.editor;
14821482

14831483
if (editor) {
@@ -1528,7 +1528,7 @@ define([
15281528
items['&Source'] = sourceItems;
15291529
}
15301530

1531-
return items;
1531+
deferred.resolve(items);
15321532
},
15331533

15341534
/**

common/src/webida/plugins/editors/viable-menu-items.js

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -80,14 +80,17 @@ define([
8080
function getItemsUnderEdit() {
8181
logger.info('getItemsUnderEdit()');
8282
var items = {};
83+
var deferred = new Deferred();
8384
var part = _getCurrentEditorPart();
8485
if (part) {
8586
var viewer = part.getViewer();
8687
if (viewer) {
87-
items = viewer.getMenuItemsUnderEdit(items, menuItems);
88+
items = viewer.getMenuItemsUnderEdit(items, menuItems, deferred);
8889
}
90+
} else {
91+
deferred.resolve(items);
8992
}
90-
return items;
93+
return deferred;
9194
}
9295

9396
function getItemsUnderFind() {
@@ -123,7 +126,6 @@ define([
123126
var naviEditorsItems = {};
124127
var itemsList = ['&Select Tab from List', '&Previous Tab', '&Next Tab', 'Move Tab to &Other Container', '&Ex-Selected Tab', 'Switch &Tab Container'];
125128

126-
127129
function getViewRunnableMenuItems(menuName) {
128130
var splitContainer = editors.splitViewContainer;
129131
var focusedVc = splitContainer.getFocusedViewContainer();
@@ -167,6 +169,7 @@ define([
167169
return false;
168170
}
169171

172+
170173
_.each(itemsList, function(item) {
171174
if (getViewRunnableMenuItems(item)) {
172175
naviEditorsItems[item] = menuItems.navMenuItems['&Navigate Editors'][item];

0 commit comments

Comments
 (0)