Feature: Add confirmation modal before sending receipt #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…by shailesh shadacharan shsha001@outlook.com
eikhr
requested changes
Mar 5, 2025
eikhr
reviewed
Mar 5, 2025
| <ModalContent> | ||
| <ModalBody> | ||
| <p className="mb-3 mt-8 text-center"> | ||
| Ved å godkjenne bekrefter jeg at beløpet stemmer med kvitteringen |
There was a problem hiding this comment.
Would be cool if this said the actual amount you have entered in the form
no |
|
Big ➕ on @eikhr 's comment about displaying the sum in the confirmation. Also curious; have you considered not using a modal for this, but rather adding a confirmation section under the buttons so that the user could still scroll up and check what's written on the receipts as well? Not saying it has to be done this way, just saying that it might be something to consider |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by shailesh shadacharan shsha001@outlook.com
Description
Added a confirmation modal that a user has to confirm before sending through the receipt. The user confirms that the amount put into the online receipt is the exact same as the amount on the original receipt.
Result
Before
Skjermopptak.2025-03-05.kl.20.31.39.mov
After
modalfilm.mov
If you've made visual changes, please check the boxes below and include images showing the changes. Descriptions are appreciated.
Testing
Resolves ABA-1327