Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken relative links #10

Open
evanwill opened this issue Jan 10, 2023 · 1 comment
Open

broken relative links #10

evanwill opened this issue Jan 10, 2023 · 1 comment
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@evanwill
Copy link

There are quite a few broken internal relative links in the docs, I was thinking of quickly fixing some, but not exactly sure your practice and the redirects going on.

There are a couple different issues, but many of them are incorrect relative paths. For example list of installation instructions the markdown has links [Find archiveweb.page in the Chrome store](installation/chromestore), where they don't need that extra level, should be [Find archiveweb.page in the Chrome store](chromestore) since they are in the same directory. While further below, the link [troubleshooting page](troubleshooting) won't work because that page is in a different directory.
To avoid the confusion of relative paths in Jekyll, I usually use either the Liquid link tag or relative_url. For example, a link to Troubleshooting could be [troubleshooting page]({% link _en/troubleshooting.md %}) or [troubleshooting page]({{ '/en/troubleshooting/' | relative_url }}).

If I create a PR would you like to use plain markdown relative links, or add Liquid?

Thank you for your work on this project!

@amandavisconti
Copy link

I think because of the internal link directory reasons above—I just noticed that on your https://archiveweb.page/en/usage/ documentation page under "troubleshooting",

  1. the link to "Check out our troubleshooting page" (https://archiveweb.page/en/usage/troubleshooting) goes to a 404,
  2. as does the "contact us" (https://archiveweb.page/en/usage/contact) link in the same paragraph

(Am finishing up the zine from yall's great Fall 2024 DIY Web Archiving workshop.) Thanks for developing and documenting this important tool @ikreymer @tw4l !

@tw4l tw4l added bug Something isn't working documentation Improvements or additions to documentation labels Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants