Fix for FB video replay #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ikreymer
commented
Nov 20, 2024
•
ikreymer
commented
- New fuzzy matching rules for FB, matching and rewriting embedded DASH (again)
- New ruleset: range-as-query args configured per domain, allows lookup of range requests set via query args
- APIs: add hasRangeAsQuery() and removeRangeAsQuery() to detect if URL has range embedded in the query args
- Part of fix for [Bug]: web-recorder can not detect facebook video archiveweb.page#272
- rewrite dash xml - add query-as-range system, remove domain-specific query params and treat as ranges - add fb rule for 'bytestart' / 'byteend' - assumes non-range query args are archived, lookup full stream and apply range
ikreymer
added a commit
that referenced
this pull request
Nov 20, 2024
Follow-up to #212, additional fixes to embedded dash manifests: - better search for end tag - don't attempt rewrite if end tag not found - bump to 2.20.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.