Skip to content

Upgrade mysql_common and mysql_async #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2025

Conversation

paolobarbolini
Copy link
Contributor

@paolobarbolini paolobarbolini commented Apr 20, 2025

This dependency bump includes a big reduction in number of indirect dependencies 1 2 when the mysql feature is enabled.

Footnotes

  1. https://github.com/blackbeam/rust_mysql_common/pulls?q=is%3Apr+author%3Apaolobarbolini+

  2. https://github.com/blackbeam/mysql_async/pulls?q=is%3Apr+author%3Apaolobarbolini+

@weiznich
Copy link
Owner

Thanks for filling ❤️

The CI seems to be fine, so lets wait on the release of mysql_async and then this seems to be ready for merging.

@paolobarbolini paolobarbolini marked this pull request as ready for review April 25, 2025 10:12
@paolobarbolini
Copy link
Contributor Author

paolobarbolini commented Apr 25, 2025

mysql_async just came out. This should now be ready.

I've bumped the mysql_common patch version to align with the minimum version required by mysql_async. Technically not necessary.

EDIT: could you also release a new version of diesel_async after merging this? I'd really appreciate getting this huge dependency cleanup out.

Copy link
Owner

@weiznich weiznich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. Lets merge this now

EDIT: could you also release a new version of diesel_async after merging this? I'd really appreciate getting this huge dependency cleanup out.

That's unfortunately not easily possible as the main branch of diesel-async depends on the master branch of diesel, so we need to wait for a release of the later before we could release the former without doing backports. For a the next non-patch diesel release some features are still missing, so if you want a fast release of diesel-async we likely need to backport this change to the released diesel-async version. I personally won't have the capacity to deal with that in the next few weeks due to other responsibilities.

(Also technically that's not even a minor diesel-async release but I major release due to the bumped supported minimal versions of mysql_common and mysql_async)

@weiznich weiznich merged commit c6f9dc8 into weiznich:main Apr 27, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants