Enable customizing runtime used for spawning blocking tasks inside the SyncConnectionWrapper #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to `BlockOn` trait defined inside `src/async_connection_wrapper.rs`, a `SpawnBlocking` trait will be introduced. Before introducing the trait, move the defined structs into `implementation` module.
…locking tasks. Previously, `SyncConnectionWrapper` was using tokio as spawning and running blocking tasks. This had prevented using Sqlite backend on wasm32-unknown-unknown target since futures generally run on top of JavaScript promises with the help of wasm_bindgen_futures crate. It is now possible for users to provide their own runtime to spawn blocking tasks inside the `SyncConnectionWrapper`.
bwqr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a generic argument to
SyncConnectionWrapperstruct to let users decide which runtime they would like to use for spawning blocking tasks while calling underlying connection's methods. The PR also definesTokioas the default runtime to both ease the usage and also to prevent causing a breaking change.With that change, users can use Sqlite connection wrapped with
SyncConnectionWrapperonwasm32-unknown-unknowntarget as tokio does not support running on this target.It resolves #233. Even though initial attempt was to provide
BatchInsertsupport for Sqlite connections wrapped withSyncConnectionWrapper, it is considered too much work to accomplish it. Instead of that, letting user access the inner connection and runBatchInsertqueries with that connection was much more reasonable, since this also allows any other unsupported queries to be executed with inner connection.