Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue with omiting endpoint #157

Merged
merged 1 commit into from
Feb 19, 2025
Merged

fix: issue with omiting endpoint #157

merged 1 commit into from
Feb 19, 2025

Conversation

edevosc2c
Copy link
Contributor

fixes #156


Seems like this change broke the functionality: cb1f39b#diff-0e426a43248661127a0c0ee115aef7a1093b635f8993b3f7ebb1dd9f05b8f249L295-R329

Reverting from:

if value, err := parseString(section, "Endpoint"); err == nil {

To

if sectionKey, err := section.GetKey("Endpoint"); err == nil {
	value := sectionKey.String()

Fixed the issue.

I'm not well versed in the code nor Golang for that to be an issue to revert to the old code, but it seems to work fine. And all the following lines still use the same method "if sectionKey, err := section." and so on.

@edevosc2c
Copy link
Contributor Author

hello @whyvl, may I know if there is anything left for merging this PR?
I have been using it in production for a whole month now and it's working great.

@whyvl
Copy link
Owner

whyvl commented Feb 19, 2025

hello @whyvl, may I know if there is anything left for merging this PR? I have been using it in production for a whole month now and it's working great.

Mb I just mostly haven't had the time to check the PRs, sorry for the lack of communication

@whyvl whyvl merged commit 9dad356 into whyvl:master Feb 19, 2025
10 checks passed
@edevosc2c
Copy link
Contributor Author

thank you! if you could create a new release, that would be awesome because there have been some new changes including this fix :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Since commit cb1f39b - unable to make wireproxy as a server, not client
2 participants