[GAL-365] Allow for non-readable files inside Galleon installation #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfdenise
reviewed
Jul 9, 2024
| @@ -162,7 +162,7 @@ private void initChildren(final FsEntry parent) throws IOException { | |||
| } | |||
| if(hasDirs) { | |||
| for(FsEntry child : parent.getChildren()) { | |||
| if(!child.dir) { | |||
| if(!child.dir || !Files.isReadable(child.p)) { | |||
There was a problem hiding this comment.
@spyrkob , is it enough? DirectoryStream stream = Files.newDirectoryStream(parent.p) (line 155) should fail if the installation root directory contains non readable directory. No?
There was a problem hiding this comment.
@jfdenise my understanding is that if the parent directory has read permission, you're able to list all the children. The problem happens when trying to create the newDirectoryStream for the child folder without read permission (line 168).
jfdenise
approved these changes
Jul 10, 2024
|
@spyrkob , FYI, the failing tests on windows are related to this fix. |
jfdenise
requested changes
Jul 10, 2024
I had to skip those tests on Windows as it doesn't seem possible to set the correct permissions on the test folders. |
|
@spyrkob , thank-you merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/GAL-365