fix extra_perms for schedule light

backend/windmill-api/src/db.rs

@@ -647,11 +647,11 @@ async fn fix_job_completed_index(db: &DB) -> Result<(), Error> {
         .await?;
     });
 
-    run_windmill_migration!("v2_jobs_rls", &db, |tx| {
-        sqlx::query!("ALTER TABLE v2_job ENABLE ROW LEVEL SECURITY")
-            .execute(db)
-            .await?;
-    });
+    // run_windmill_migration!("v2_jobs_rls", &db, |tx| {
+    //     sqlx::query!("ALTER TABLE v2_job ENABLE ROW LEVEL SECURITY")
+    //         .execute(db)
+    //         .await?;
+    // });
 
     Ok(())
 }

backend/windmill-api/src/schedule.rs

@@ -341,6 +341,7 @@ pub struct ScheduleLight {
     pub script_path: String,
     pub is_flow: bool,
     pub summary: Option<String>,
+    pub extra_perms: serde_json::Value,
 }
 async fn list_schedule(
     authed: ApiAuthed,
@@ -351,7 +352,7 @@ async fn list_schedule(
     let mut tx = user_db.begin(&authed).await?;
     let (per_page, offset) = paginate(Pagination { per_page: lsq.per_page, page: lsq.page });
     let mut sqlb = SqlBuilder::select_from("schedule")
-        .field("workspace_id, path, edited_by, edited_at, schedule, timezone, enabled, script_path, is_flow, summary")
+        .field("workspace_id, path, edited_by, edited_at, schedule, timezone, enabled, script_path, is_flow, summary, extra_perms")
         .order_by("edited_at", true)
         .and_where("workspace_id = ?".bind(&w_id))
         .offset(offset)

frontend/src/lib/components/SharedBadge.svelte

@@ -17,17 +17,17 @@
 			let username = $userStore?.username ?? ''
 			let pgroups = $userStore?.pgroups ?? []
 			let pusername = `u/${username}`
-			let extraPermsKeys = Object.keys(extraPerms)
+			let extraPermsKeys = Object.keys(extraPerms ?? {})
 
 			if (pusername in extraPermsKeys) {
-				if (extraPerms[pusername]) {
+				if (extraPerms?.[pusername]) {
 					kind = 'write'
 				} else {
 					kind = 'read'
 				}
 				reason = 'This item was shared to you personally'
 			} else {
-				let writeGroup = pgroups.find((x) => extraPermsKeys.includes(x) && extraPerms[x])
+				let writeGroup = pgroups.find((x) => extraPermsKeys.includes(x) && extraPerms?.[x])
 				if (writeGroup) {
 					kind = 'write'
 					reason = `This item was write shared to the group ${writeGroup} which you are a member of`

frontend/src/lib/utils.ts

@@ -82,9 +82,9 @@ export function displayDate(
 		}
 		const dateChoices: Intl.DateTimeFormatOptions = displayDate
 			? {
-					day: 'numeric',
-					month: 'numeric'
-			  }
+				day: 'numeric',
+				month: 'numeric'
+			}
 			: {}
 		return date.toLocaleString(undefined, {
 			...timeChoices,
@@ -351,7 +351,7 @@ export function removeItemAll<T>(arr: T[], value: T) {
 }
 
 export function emptyString(str: string | undefined | null): boolean {
-	return str === undefined || str === null || str === '' 
+	return str === undefined || str === null || str === ''
 }
 
 export function emptyStringTrimmed(str: string | undefined | null): boolean {
@@ -705,18 +705,18 @@ export function canWrite(
 	if (user?.is_admin || user?.is_super_admin) {
 		return true
 	}
-	let keys = Object.keys(extra_perms)
+	let keys = Object.keys(extra_perms ?? {})
 	if (!user) {
 		return false
 	}
 	if (isObviousOwner(path, user)) {
 		return true
 	}
 	let userOwner = `u/${user.username}`
-	if (keys.includes(userOwner) && extra_perms[userOwner]) {
+	if (keys.includes(userOwner) && extra_perms?.[userOwner]) {
 		return true
 	}
-	if (user.pgroups.findIndex((x) => keys.includes(x) && extra_perms[x]) != -1) {
+	if (user.pgroups.findIndex((x) => keys.includes(x) && extra_perms?.[x]) != -1) {
 		return true
 	}
 	if (user.folders.findIndex((x) => path.startsWith('f/' + x + '/') && user.folders[x]) != -1) {
@@ -846,7 +846,7 @@ export async function tryEvery({
 		try {
 			await tryCode()
 			break
-		} catch (err) {}
+		} catch (err) { }
 		i++
 	}
 	if (i >= times) {