Skip to content

Commit db873be

Browse files
committed
nit editors reactivity on change
1 parent ed61d97 commit db873be

File tree

3 files changed

+12
-18
lines changed

3 files changed

+12
-18
lines changed

frontend/src/lib/components/Editor.svelte

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -367,13 +367,13 @@
367367
}
368368
}
369369
370-
function updateCode(): boolean {
370+
function updateCode() {
371371
const ncode = getCode()
372372
if (code == ncode) {
373-
return false
373+
return
374374
}
375375
code = ncode
376-
return true
376+
dispatch('change', ncode)
377377
}
378378
379379
export function append(code: string): void {
@@ -1287,9 +1287,7 @@
12871287
editor?.onDidChangeModelContent((event) => {
12881288
timeoutModel && clearTimeout(timeoutModel)
12891289
timeoutModel = setTimeout(() => {
1290-
if (updateCode()) {
1291-
dispatch('change', code)
1292-
}
1290+
updateCode()
12931291
}, changeTimeout)
12941292
12951293
ataModel && clearTimeout(ataModel)

frontend/src/lib/components/SimpleEditor.svelte

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -163,13 +163,13 @@
163163
editor?.setValue(ncode)
164164
}
165165
166-
function updateCode(): boolean {
166+
function updateCode() {
167167
const ncode = getCode()
168168
if (code == ncode) {
169-
return false
169+
return
170170
}
171171
code = ncode
172-
return true
172+
dispatch('change', ncode)
173173
}
174174
175175
function updatePlaceholderVisibility(value: string) {
@@ -379,9 +379,7 @@
379379
suggestion = ''
380380
timeoutModel && clearTimeout(timeoutModel)
381381
timeoutModel = setTimeout(() => {
382-
if (updateCode()) {
383-
dispatch('change', { code })
384-
}
382+
updateCode()
385383
}, 200)
386384
})
387385

frontend/src/lib/components/TemplateEditor.svelte

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -472,22 +472,20 @@
472472
editor.addCommand(KeyMod.CtrlCmd | KeyMod.Shift | KeyCode.Digit7, function () {})
473473
})
474474
475-
function updateCode(): boolean {
475+
function updateCode() {
476476
const ncode = getCode()
477477
if (code == ncode) {
478-
return false
478+
return
479479
}
480480
code = ncode
481-
return true
481+
dispatch('change', code)
482482
}
483483
484484
let timeoutModel: NodeJS.Timeout | undefined = undefined
485485
editor.onDidChangeModelContent((event) => {
486486
timeoutModel && clearTimeout(timeoutModel)
487487
timeoutModel = setTimeout(() => {
488-
if (updateCode()) {
489-
dispatch('change', { code })
490-
}
488+
updateCode()
491489
}, 200)
492490
})
493491

0 commit comments

Comments
 (0)