chore(main): release 1.392.0 #4341
Conversation
Deploying windmill with
|
| Latest commit: |
2963324
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c7985cec.windmill.pages.dev |
| Branch Preview URL: | https://release-please--branches--ma.windmill.pages.dev |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to a53eb00 in 6 seconds
More details
- Looked at
26lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. version.txt:1
- Draft comment:
Ensure the version number here matches the intended release version. It currently matches the PR description, which is correct. - Reason this comment was not posted:
Confidence changes required:0%
The version number in version.txt has been correctly updated to 1.391.1, matching the release version in the PR description.
Workflow ID: wflow_eJUBbzar0045F2Ad
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
rubenfiszel
force-pushed
the
release-please--branches--main--components--windmill
branch
from
6e69bc0 to
8ff5dc8
Compare
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 8ff5dc8 in 16 seconds
More details
- Looked at
30lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. version.txt:1
- Draft comment:
Remove the 'L1:' prefix. The file should only contain the version number '1.392.0'. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The comment is about a change in the file, specifically the format of the version number. The comment suggests a code change, which is to remove the 'L1:' prefix. This seems to be a valid suggestion if the file is expected to only contain the version number without any prefix.
I might be assuming that the 'L1:' prefix is incorrect without knowing the context of its usage. There could be a reason for its presence that is not apparent from the diff alone.
The comment is actionable and suggests a specific change. If the file is indeed supposed to only contain the version number, then the comment is valid.
Keep the comment as it suggests a specific and actionable change regarding the format of the version number in the file.
Workflow ID: wflow_H4CZ6AlsNd82uraX
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
rubenfiszel
force-pushed
the
release-please--branches--main--components--windmill
branch
from
25107cb to
bc1e9cc
Compare
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on bc1e9cc in 14 seconds
More details
- Looked at
30lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. version.txt:1
- Draft comment:
Ensure the version number here matches the intended release version. It should be 1.392.0 as per the PR description. - Reason this comment was not posted:
Confidence changes required:0%
The version.txt file has been updated correctly to reflect the new version 1.392.0, which matches the release version in the PR description.
Workflow ID: wflow_aU4M6Rp2vmD5DhGl
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
rubenfiszel
force-pushed
the
release-please--branches--main--components--windmill
branch
from
853b709 to
7d975d6
Compare
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 7d975d6 in 16 seconds
More details
- Looked at
30lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. version.txt:1
- Draft comment:
Ensure the version number here matches the intended release version. It should be 1.392.0 as per the PR description. - Reason this comment was not posted:
Confidence changes required:0%
The version.txt file has been updated correctly to reflect the new version 1.392.0, which matches the release version in the PR description.
Workflow ID: wflow_WAiVAc265usc8fHN
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
rubenfiszel
force-pushed
the
release-please--branches--main--components--windmill
branch
from
12ea103 to
1cbd5ff
Compare
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 1cbd5ff in 15 seconds
More details
- Looked at
31lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. version.txt:1
- Draft comment:
Ensure the version number here matches the intended release version. It should be 1.392.0 as per the PR description. - Reason this comment was not posted:
Confidence changes required:0%
The version.txt file has been updated correctly to reflect the new version 1.392.0, which matches the release version in the PR description.
Workflow ID: wflow_o6NjJuwlri12AIcg
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
rubenfiszel
force-pushed
the
release-please--branches--main--components--windmill
branch
from
e6f5bb8 to
1032859
Compare
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 1032859 in 16 seconds
More details
- Looked at
32lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. version.txt:1
- Draft comment:
Ensure the version number here matches the intended release version. It currently matches the PR description, which is correct. - Reason this comment was not posted:
Confidence changes required:0%
The version number in version.txt has been correctly updated to 1.392.0, matching the release version in the PR description.
Workflow ID: wflow_McmpJGZVML5q7VsQ
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
rubenfiszel
force-pushed
the
release-please--branches--main--components--windmill
branch
from
1032859 to
b8ac748
Compare
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on b8ac748 in 13 seconds
More details
- Looked at
32lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. version.txt:1
- Draft comment:
Ensure the version number here matches the intended release version. It should be 1.392.0 as per the PR description. - Reason this comment was not posted:
Confidence changes required:0%
The version.txt file has been updated correctly to reflect the new version 1.392.0, which matches the release version in the PR description.
Workflow ID: wflow_X7c375p2rXzF3KNz
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
rubenfiszel
force-pushed
the
release-please--branches--main--components--windmill
branch
from
87629ae to
9e1d22d
Compare
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 9e1d22d in 11 seconds
More details
- Looked at
32lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. version.txt:1
- Draft comment:
Ensure the version number here matches the intended release version. It should be 1.392.0 as per the PR description. - Reason this comment was not posted:
Confidence changes required:0%
The version number in version.txt has been correctly updated to 1.392.0, matching the release version in the PR description.
Workflow ID: wflow_bx1Js724G8DpUn4g
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
rubenfiszel
force-pushed
the
release-please--branches--main--components--windmill
branch
from
355f87d to
9f0faa8
Compare
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 9f0faa8 in 17 seconds
More details
- Looked at
32lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. version.txt:1
- Draft comment:
Remove the 'L1:' prefix. The file should only contain the version number itself. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The comment is addressing a change in the file, specifically the format of the version number. The presence of 'L1:' in the version number seems unusual and could be a formatting error. The comment is actionable as it suggests a specific change to the file content.
The comment assumes that the 'L1:' prefix is incorrect without context. There might be a valid reason for its presence that the comment does not consider.
Given the context provided, the 'L1:' prefix does not seem standard for a version number, and the comment is suggesting a reasonable action to correct it.
The comment should be kept as it addresses a potential formatting issue in the version number that was changed in the diff.
Workflow ID: wflow_9KerZ3gfg4LFHaO4
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
rubenfiszel
force-pushed
the
release-please--branches--main--components--windmill
branch
from
d48a050 to
b374364
Compare
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on b374364 in 26 seconds
More details
- Looked at
33lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. version.txt:1
- Draft comment:
The version number should not have any prefix like 'L1:'. It should be just the version number.
1.392.0
- Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The comment is addressing a prefix 'L1:' that is present in the new content of the file. However, the diff does not show this prefix being added, which means it was likely already there. The comment is not about a change made in the diff, so it should be removed according to the rules.
I might be missing the context of why the prefix 'L1:' is there, but since it wasn't changed in this diff, the comment is not relevant to the changes made.
The rules clearly state not to comment on unchanged code, so the presence of 'L1:' in the new content is not relevant to this review.
The comment should be deleted because it addresses an issue not related to the changes made in the diff.
Workflow ID: wflow_iZh5EqyVdm8NXypb
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
rubenfiszel
force-pushed
the
release-please--branches--main--components--windmill
branch
from
62abfe9 to
bd22a24
Compare
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on bd22a24 in 12 seconds
More details
- Looked at
34lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. version.txt:1
- Draft comment:
The version number has been correctly updated to 1.392.0, matching the release version in the PR description and changelog. - Reason this comment was not posted:
Confidence changes required:0%
The version.txt file has been updated correctly to reflect the new version 1.392.0. This matches the release version in the PR description and changelog.
Workflow ID: wflow_vveuq55nTL1O5FBE
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
rubenfiszel
force-pushed
the
release-please--branches--main--components--windmill
branch
from
fdee905 to
6485615
Compare
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 6485615 in 15 seconds
More details
- Looked at
35lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. version.txt:1
- Draft comment:
The version.txt file should only contain the version number without any prefixes like 'L1:'. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The comment is addressing a change in the file, specifically the format of the version number. The new content includes a prefix 'L1:', which the comment suggests should not be there. This seems to be a valid point about the change made in the diff.
The comment assumes that the prefix 'L1:' is incorrect without context. There might be a valid reason for this prefix that the comment does not consider.
While there could be a reason for the prefix, the comment is directly addressing a change in the file and suggests a potential issue with the format, which is relevant to the diff.
The comment is relevant to the change made in the diff and addresses a potential issue with the format of the version number. It should be kept.
Workflow ID: wflow_6uOlNQ8SrXpEoXSH
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
rubenfiszel
deleted the
release-please--branches--main--components--windmill
branch
|
🤖 Release is at https://github.com/windmill-labs/windmill/releases/tag/v1.392.0 🌻 |
🤖 I have created a release beep boop
1.392.0 (2024-09-06)
Features
Bug Fixes
This PR was generated with Release Please. See documentation.
Summary:
Release version 1.392.0 with new features and bug fixes, including 'load more' on runs page and schedule success handler.
Key points:
nativetsarguments.Generated with ❤️ by ellipsis.dev