-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
send stats when renewing key if last >24h #4430
Merged
rubenfiszel
merged 10 commits into
main
from
hugo/win-379-resend-usage-when-renewing-if-24h
Sep 30, 2024
Merged
send stats when renewing key if last >24h #4430
rubenfiszel
merged 10 commits into
main
from
hugo/win-379-resend-usage-when-renewing-if-24h
Sep 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5ae9b5a
to
c4d857b
Compare
ec6b974
to
8e0eb3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 3777a95 in 30 seconds
More details
- Looked at
362
lines of code in15
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. backend/windmill-common/src/utils.rs:233
- Draft comment:
Usingunwrap
here can lead to a panic if the string does not start with a '/'. Consider usingunwrap_or
or handling theNone
case explicitly. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_knjQOw4VCQvq3Sxq
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add feature to send stats when renewing a key if last renewal was over 24 hours ago, with refactoring and minor fixes.
settings.rs
.renew_license_key
to includeRenewReason
inee.rs
.generate_lock_id
function fromdb.rs
toutils.rs
.instance_name
variable inmain.rs
.Cargo.toml
.ee-repo-ref.txt
.This description was created by
for 3777a95. It will automatically update as commits are pushed.