Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send stats when renewing key if last >24h #4430

Merged
merged 10 commits into from
Sep 30, 2024

Conversation

HugoCasa
Copy link
Contributor

@HugoCasa HugoCasa commented Sep 24, 2024

  • feat: tag filtering jwt ext auth
  • move tags to scopes
  • fix symlink
  • update ee ref
  • feat: send stats when renewing key if last >24h

Important

Add feature to send stats when renewing a key if last renewal was over 24 hours ago, with refactoring and minor fixes.

  • Behavior:
    • Send stats when renewing a key if the last renewal was over 24 hours ago in settings.rs.
    • Refactor renew_license_key to include RenewReason in ee.rs.
  • Refactoring:
    • Move generate_lock_id function from db.rs to utils.rs.
    • Remove unused instance_name variable in main.rs.
  • Misc:
    • Fix symlink issue in Cargo.toml.
    • Update enterprise edition reference in ee-repo-ref.txt.

This description was created by Ellipsis for 3777a95. It will automatically update as commits are pushed.

@HugoCasa HugoCasa changed the base branch from main to hugo/win-373-tag-filtering-jwt-ext-auth September 24, 2024 13:15
Copy link

cloudflare-workers-and-pages bot commented Sep 24, 2024

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: a482752
Status:⚡️  Build in progress...

View logs

@HugoCasa HugoCasa changed the title feat: send stats when renewing key if last >24h send stats when renewing key if last >24h Sep 24, 2024
@HugoCasa HugoCasa force-pushed the hugo/win-379-resend-usage-when-renewing-if-24h branch from 5ae9b5a to c4d857b Compare September 24, 2024 22:13
@HugoCasa HugoCasa changed the base branch from hugo/win-373-tag-filtering-jwt-ext-auth to main September 24, 2024 22:13
@rubenfiszel rubenfiszel force-pushed the main branch 3 times, most recently from ec6b974 to 8e0eb3d Compare September 26, 2024 12:31
@HugoCasa HugoCasa marked this pull request as ready for review September 30, 2024 08:16
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 3777a95 in 30 seconds

More details
  • Looked at 362 lines of code in 15 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. backend/windmill-common/src/utils.rs:233
  • Draft comment:
    Using unwrap here can lead to a panic if the string does not start with a '/'. Consider using unwrap_or or handling the None case explicitly.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_knjQOw4VCQvq3Sxq


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@rubenfiszel rubenfiszel merged commit c600a62 into main Sep 30, 2024
2 of 3 checks passed
@rubenfiszel rubenfiszel deleted the hugo/win-379-resend-usage-when-renewing-if-24h branch September 30, 2024 10:23
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants