Small clarification message about all flow triggers #4441
Conversation
hcourdent
requested review from
fatonramadani and
rubenfiszel
as code owners
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to e6ff31c in 16 seconds
More details
- Looked at
18lines of code in1files - Skipped
2files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_8vUVDONTjEEmP9H1
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| > | ||
| It prepares arguments for the flow. Besides request arguments, the preprocessor receives a | ||
| `wm_trigger` argument with trigger details. | ||
| `wm_trigger` argument with trigger details. Learn more about all flow triggers | ||
| <a href="https://www.windmill.dev/docs/getting_started/trigger_flows" target="_blank">here</a>. |
There was a problem hiding this comment.
Consider adding rel="noopener noreferrer" to the anchor tag for security reasons when using target="_blank". This prevents the new page from having access to the window.opener property, which can be a security risk.
Deploying windmill with
|
| Latest commit: |
9dcddf8
|
| Status: | ⚡️ Build in progress... |
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 9dcddf8 in 7 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. frontend/src/lib/components/flows/content/FlowModuleWrapper.svelte:103
- Draft comment:
Addingrel="noopener noreferrer"is a good security practice when usingtarget="_blank". It prevents potential security vulnerabilities by not allowing the new page to access thewindow.openerproperty. - Reason this comment was not posted:
Confidence changes required:0%
The addition ofrel="noopener noreferrer"is a security best practice when usingtarget="_blank". It prevents the new page from having access to thewindow.openerproperty, which can be a security risk.
Workflow ID: wflow_hTr16ckBZBvRXI7U
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Important
Enhance
FlowModuleWrapper.sveltealert message with a hyperlink to flow triggers documentation.FlowModuleWrapper.svelte, updated the alert message for the preprocessor step to include a hyperlink to documentation on flow triggers.This description was created by
for 9dcddf8. It will automatically update as commits are pushed.