fix windows build

[pyranota]

Important

Fix Windows build by changing start_child_process command to "uv" in spawn_uv_install() in python_executor.rs.

• Windows Build Fix:
  • In spawn_uv_install() in python_executor.rs, change start_child_process command from installer_path to "uv" for Windows platform.

^{This description was created by for 668a872. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 668a872 in 44 seconds

More details

• Looked at 13 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 9 drafted comments based on config settings.

1. backend/windmill-worker/src/python_executor.rs:1589

• Draft comment:
  Windows build fix: Using Command::new("uv") on Windows now instead of relying on UV_PATH. Ensure that this matches expected behavior (i.e. that 'uv' is in PATH) and consider adding a comment clarifying this decision.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

2. backend/windmill-worker/src/python_executor.rs:1673

• Draft comment:
  Windows branch now uses a literal 'uv' instead of UV_PATH. This may fix the build, but consider if Windows users might need a configurable path similar to Unix.
• Reason this comment was not posted:
  Confidence changes required: 50% <= threshold 50%
  None

3. backend/windmill-worker/src/python_executor.rs:1683

• Draft comment:
  Consider replacing the hardcoded '/tmp' fallback with std::env::temp_dir() on Windows for a more platform-appropriate temporary directory.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

4. backend/windmill-worker/src/python_executor.rs:685

• Draft comment:
  Typo: In the comment, 'guranteed' should be corrected to 'guaranteed'.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

5. backend/windmill-worker/src/python_executor.rs:1000

• Draft comment:
  Typo: 'Usefull' should be changed to 'Useful'.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

6. backend/windmill-worker/src/python_executor.rs:1017

• Draft comment:
  Typo: 'priorotized' should be corrected to 'prioritized'.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

7. backend/windmill-worker/src/python_executor.rs:2090

• Draft comment:
  Typo: The word 'proccess' is misspelled; it should be 'process'.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

8. backend/windmill-worker/src/python_executor.rs:910

• Draft comment:
  Typo: In the Python snippet, 'kwrags_json' should be corrected to 'kwargs_json'.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

9. backend/windmill-worker/src/python_executor.rs:1356

• Draft comment:
  Typo: The error message says '(last part of path ma)'. It likely should be corrected to something like '(last part of path must contain "/PIP_SECRET_")'.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_gUVbWFZwMvZifEHk

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[cloudflare-workers-and-pages]

Deploying windmill with    Cloudflare Pages

Latest commit:	668a872
Status:	✅  Deploy successful!
Preview URL:	https://4d3e73ce.windmill.pages.dev
Branch Preview URL:	https://py-fix-windows-build-after-p-43j6.windmill.pages.dev

View logs