Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove db streaming to avoid backpressure on db #5342

Merged

Conversation

wendrul
Copy link
Contributor

@wendrul wendrul commented Feb 20, 2025

Important

Add time feature to tokio in Cargo.toml to address database backpressure issues.

  • Dependencies:
    • Add time feature to tokio in Cargo.toml to improve time management in async operations.
  • Misc:
    • Update ee-repo-ref.txt to new commit hash b5f4243f5649d972e8722ce134c7cf5256d131d6.

This description was created by Ellipsis for c235427. It will automatically update as commits are pushed.

@wendrul wendrul requested a review from rubenfiszel as a code owner February 20, 2025 13:21
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 3738da7 in 36 seconds

More details
  • Looked at 21 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 5 drafted comments based on config settings.
1. backend/Cargo.toml:168
  • Draft comment:
    Verify why the 'time' feature was added to tokio. Is it required to support new timer functionality?
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    The comment is asking the PR author to verify the reason for adding the 'time' feature to tokio. This is asking for confirmation and explanation, which violates the rules.
2. backend/ee-repo-ref.txt:1
  • Draft comment:
    Ensure that the updated commit hash is correct and reflects the intended changes.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    This comment is asking the PR author to ensure that the commit hash is correct, which falls under the rule of not asking the author to double-check things. It doesn't provide a specific suggestion or point out a specific issue.
3. backend/Cargo.toml:168
  • Draft comment:
    Why add the 'time' feature to tokio? Document the reason for this change.
  • Reason this comment was not posted:
    Marked as duplicate.
4. backend/ee-repo-ref.txt:1
  • Draft comment:
    Commit hash updated; consider adding a newline at end-of-file for consistency.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50%
    None
5. backend/Cargo.toml:29
  • Draft comment:
    In the workspace members array, the item on line 29 is listed as "windmill-macros" without a './' prefix, while all other members use a relative path format (e.g., "./windmill-macros"). Please check if this is intentional or if it should be corrected to "./windmill-macros" to maintain consistency.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_vmQCUXPyCB2Mgz8g


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: c235427
Status:⚡️  Build in progress...

View logs

@rubenfiszel rubenfiszel merged commit 9ba66ea into main Feb 20, 2025
5 of 7 checks passed
@rubenfiszel rubenfiszel deleted the win-973-add-timeout-on-job-select-for-indexer-migration-issue branch February 20, 2025 13:27
@github-actions github-actions bot locked and limited conversation to collaborators Feb 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants