fix click outside popover fullscreen

[diegoimbert]

Important

Fix Popover.svelte to exit fullscreen mode before closing on outside click.

• Behavior:
  • In Popover.svelte, modify on:pointerdown_outside to exit fullscreen mode before closing the popover.
  • Handles case where fullScreen is true by setting it to false instead of closing immediately.

^{This description was created by for f1e89c4. It will automatically update as commits are pushed.}

[github-actions]

Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

---

I have read the CLA Document and I hereby sign the CLA

---

Diego Imbert seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to f1e89c4 in 32 seconds

More details

• Looked at 14 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 2 drafted comments based on config settings.

1. frontend/src/lib/components/meltComponents/Popover.svelte:117

• Draft comment:
  In the pointerdown_outside handler, the diff now checks if fullScreen is true and only toggles it off rather than closing the popover. Ensure that this behavior is intended (i.e., click outside should exit fullscreen mode without closing the popover). Consider adding a short inline comment to document this design decision.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 50% <= threshold 50%
  The comment is asking the author to ensure that the behavior is intended, which violates the rules. However, it also suggests adding an inline comment to document the design decision, which is a valid suggestion. The comment is partially useful, but the part about ensuring the behavior is intended should be removed.

2. frontend/src/lib/components/meltComponents/Popover.svelte:117

• Draft comment:
  Ensure that toggling off fullscreen (setting fullScreen = false) on pointerdown outside is the intended UX—this leaves the popover open in non-fullscreen mode. Consider adding braces or a clarifying comment for readability.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 50% <= threshold 50%
  The comment is asking the author to confirm the intended UX behavior when toggling fullscreen off, which is not allowed. However, it also suggests adding braces or a clarifying comment for readability, which is a valid suggestion. The comment is partially useful.

Workflow ID: wflow_5OGJq7hw1Yw15DGN

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[cloudflare-workers-and-pages]

Deploying windmill with    Cloudflare Pages

Latest commit:	b0491bd
Status:	✅  Deploy successful!
Preview URL:	https://fb4aeeb2.windmill.pages.dev
Branch Preview URL:	https://di-fix-popover-fullscreen-cl.windmill.pages.dev

View logs