Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanted to add additional volumes so I could persist the mappings.
Found out that there is no way to do that sadly.
Values Keys
.Values.revisionHistoryLimit
Quality of life option for people using CD applications like Flux or Argo.
Defaults to 10 to keep default behaviour
.Values.persistence
The main bulk of this PR.
Split into
mappings
andresponses
.Values.persistence.*.enabled
Default to
false
for backwards compatibility..Values.persistence.*.accessModes
Defaults to
["ReadWriteOnce"]
.Values.persistence.*.size
Defaults to
10Gi
.Values.persistence.*.storageClassName
The difference between
storageClassName: ""
and thestorageClassName
key being omitted are significantI am using the same trick that grafana/helm-charts uses to allow a user omit the key, or set it to
""
.Helm makes this hard as "" is falsy.
If you can think of a better trick, I am all ears.
By using the
storageClassName
of"-"
in the values, it will template to""
,and not specifying the key will not include it in the resource
Defaults to being omitted as per recommendation
.Values.extraVolumes
Templates new Volumes onto the deployment resource.
Used to attach arbitrary extra volumes.
Defaults to empty
.Values.extraVolumeMounts
Templates extra Volume Mounts on the wiremock container, used in conjunction with the above
Defaults to empty
.Values.initContainer.extraVolumeMounts
Templates extra Volume Mounts on the wiremock Init Container, used in conjunction with the
extraVolumes
key.Defaults to empty
.Values.extraObjects
Shamelessly borrowed from grafana/helm-charts
Very useful to deploy External Secrets resources or
to Network Resources like Istio / Traefik that need the port-numbers.
See the example for usage.
Defaults to empty
Notes
Playing around, with the default of ReadWriteOnce, I observed some rolling update issues with the volume being stuck to a specific pod.
The new pod can then never get the volume becuase it's currently attached to the old one.
Fix looks to be to change the deployment stratagy.
I want your input on this.
Submitter checklist
#help-contributing
or a project-specific channel like#wiremock-java