Replace os.path with pathlib.Path
#246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17o2
force-pushed
the
feature/technical-drw
branch
from
293c896 to
b513051
Compare
laurierloi
reviewed
Nov 17, 2021
kvid
requested changes
Jan 9, 2022
There was a problem hiding this comment.
I also like the pathlib interface. Consider the change suggested by @laurierloi and a few other code alternatives.
kvid
reviewed
Jan 9, 2022
|
All comments have been addressed inside #251 or are no longer relevant after 251 is applied |
laurierloi
pushed a commit
to laurierloi/WireViz
that referenced
this pull request
Jan 19, 2023
kvid
pushed a commit
to kvid/WireViz
that referenced
this pull request
Aug 27, 2023
kvid
pushed a commit
to kvid/WireViz
that referenced
this pull request
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #190.