Skip to content

Commit 9461fc5

Browse files
committed
unify sessions and connections results
1 parent bdf483c commit 9461fc5

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

app/src/main/java/vproxyapp/app/cmd/Command.java

+5-1
Original file line numberDiff line numberDiff line change
@@ -797,7 +797,11 @@ private CmdResult runThrow() throws Exception {
797797
return new CmdResult(sessCount, sessCount, "" + sessCount);
798798
case L:
799799
List<Session> sessList = SessionHandle.list(targetResource);
800-
List<List<String>> sessTupleList = sessList.stream().map(sess -> Arrays.asList(sess.active.id(), sess.passive.id())).collect(Collectors.toList());
800+
List<List<String>> sessTupleList = sessList.stream().map(sess ->
801+
Arrays.asList(
802+
new ConnectionHandle.Conn(sess.active, true).toString(),
803+
new ConnectionHandle.Conn(sess.passive, false).toString()
804+
)).collect(Collectors.toList());
801805
return new CmdResult(sessList, sessTupleList, utilJoinList(sessList));
802806
case R:
803807
SessionHandle.close(this);

test/src/test/java/vproxy/ci/CI.java

+1-7
Original file line numberDiff line numberDiff line change
@@ -1306,13 +1306,7 @@ public void channelAndStateAndStatistics() throws Exception {
13061306
assertTrue(connections.contains("127.0.0.1:" + port + "/127.0.0.1:" + sock3.localAddress().port() + "[ESTABLISHED]"));
13071307
assertEquals(3, querySessions(createReq(list_detail, "session", "in", "tcp-lb", lbName)).size());
13081308
var sessionsResult = querySessions(createReq(list_detail, "session", "in", "tcp-lb", lbName));
1309-
var connectionsResult = connections.stream().map(s -> s.substring(0, s.length() - "[ESTABLISHED]".length()))
1310-
.map(s -> {
1311-
var split = s.split("/");
1312-
return split[1] + "/" + split[0];
1313-
})
1314-
.collect(Collectors.toList());
1315-
assertTrue(sessionsResult.stream().flatMap(Collection::stream).collect(Collectors.toSet()).containsAll(connectionsResult));
1309+
assertTrue(sessionsResult.stream().flatMap(Collection::stream).collect(Collectors.toSet()).containsAll(connections));
13161310

13171311
// server
13181312
assertEquals(2, count(createReq(list, "connection", "in", "server", "sg7771", "in", "server-group", sg0)));

0 commit comments

Comments
 (0)