Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check examples consistency #173

Closed
wants to merge 15 commits into from
Closed

Check examples consistency #173

wants to merge 15 commits into from

Conversation

antje-s
Copy link
Contributor

@antje-s antje-s commented Jan 31, 2024 •
edited
Loading

I tried to group the examples and then compared them within the group...

  1. observations
  • ca-eccc-msc.surface-weather-observations-realtime.json
  • cn-cma-nmic.surface-based-observations.json
  • de-dwd.surface-weather-observations-realtime.json

Open questions:

  • Should under links.href for data notifications as value not be own MQTT broker address or may placeholder like "mqtts://example.org" be used here?
  1. Global Services
  • ca-eccc-msc-gdc.global-discovery-catalogue.json
  • fr-meteo-france.global-broker.json
  • de-dwd.global-cache.json
  1. NWP
  • ca-eccc-msc.cmip5-tt.json
  • ca-eccc-msc.nwp-gdps.json
  • cn-cma-nmic.prediction-forecast.json
  • de-dwd.icon-eps-all.json
  • us-noaa-nws.gfs-10deg.json
  1. Hydrology
  • ca-eccc-msc.hydrometric-archive.json (--> "mqtts://example.org" ok?)
  • ca-eccc-msc.hydrometric-realtime.json (--> "mqtts://example.org" ok?)
  1. Satellite
  • us-noaa-nws.goes16-satellite-sst.json
  • int-eumetsat-serviri-core.json
  1. Climate
  • ca-eccc-msc.daily-climate-observations.json (--> "mqtts://example.org" ok?)

5 TODO

All changes are only proposals and need further reviews/discussion...

antje-s added 15 commits January 31, 2024 09:11
@antje-s
Check examples consistency
555c00e
@antje-s
Update ca-eccc-msc.surface-weather-observations-realtime.json
3d6a309
@antje-s
Update ca-eccc-msc.surface-weather-observations-realtime.json
9f728c0
@antje-s
Update ca-eccc-msc.surface-weather-observations-realtime.json
2cd4b4e 
for consistency to Table 4. Link relation selection
@antje-s
Update de-dwd.global-cache.json
9f9ba97 
only for consistency
@antje-s
Update fr-meteo-france.global-broker.json
7eb2ec9 
codelist-name changed
@antje-s
Update ca-eccc-msc-gdc.global-discovery-catalogue.json
2ad1716 
codelist name changed
@antje-s
Update ca-eccc-msc-gdc.global-discovery-catalogue.json
295f486
@antje-s
Update de-dwd.global-cache.json
3c2aaa3 
for consistency
@antje-s
Update fr-meteo-france.global-broker.json
381b383 
Should we delete other GB links with "related" as otherwise updates to the metadata are always necessary when additional GBs go into operation?
@antje-s
Update ca-eccc-msc-gdc.global-discovery-catalogue.json
47828ae 
Should we add a link to the UI and adapt the archive link to a direct link to the archive of all metadata from the GDC?
@antje-s
Update us-noaa-nws.gfs-10deg.json
c7aad0c 
- keywordsCodespace changed to themes/concepts/scheme
- keywords list should be further reduced and if possible moved to themes/concepts (only started as proposal)
- license - wmo:dataPolicy
- contact.links in my opinion for information not data
@antje-s
Update us-noaa-nws.gfs-10deg.json
7971ecb 
duplicated wmo:dataPolicy due to replacement WMOOther
@antje-s
Update cn-cma-nmic.prediction-forecast.json
9589d19 
only own MQTT WIS2 Node Broker, replaced by GDC with all GBs
@antje-s
Update cn-cma-nmic.prediction-forecast.json
34ff406 
to be reviewed, but topic should be origin/a/wis2/<own centre_id>/...
@antje-s antje-s marked this pull request as ready for review January 31, 2024 15:17
@tomkralidis tomkralidis mentioned this pull request Feb 5, 2024
Merged
@tomkralidis
Copy link
Collaborator

Excellent work @antje-s. Given updates in #177, I am closing this PR and folding your updates into #178.

@tomkralidis tomkralidis closed this Feb 5, 2024
@tomkralidis tomkralidis deleted the example_consistency_checks branch February 5, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antje-s @tomkralidis