Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WCMP2 and internal message bus fixes #628

Merged
merged 5 commits into from
Feb 27, 2024
Merged

WCMP2 and internal message bus fixes #628

merged 5 commits into from
Feb 27, 2024

Conversation

tomkralidis
Copy link
Collaborator

No description provided.

@tomkralidis tomkralidis added this to the sprint-014 milestone Feb 12, 2024
Copy link
Collaborator

@maaikelimper maaikelimper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The action triggered for topic='wis2box/dataset/unpublication' removes the collection but does not appear to trigger a WIS2-notification, is this intentional ?

@maaikelimper maaikelimper self-requested a review February 12, 2024 16:38
Copy link
Collaborator

@maaikelimper maaikelimper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved regardless of my comment as there is currently no workflow using the topic 'wis2box/dataset/unpublication' ....

@maaikelimper maaikelimper merged commit 96be688 into main Feb 27, 2024
2 checks passed
@maaikelimper maaikelimper deleted the wcmp2-fix branch February 27, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants