Skip to content

Commit

Permalink
Fix failed unit test: store length before editing a dictionary
Browse files Browse the repository at this point in the history
The new database is edited by the call to merge_databases(), so its length muse be stored beforehand.
  • Loading branch information
woctezuma committed Jan 1, 2025
1 parent e38173a commit 6af51bd
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -859,12 +859,13 @@ def test_merge_databases_where_entry_is_updated() -> None:
def test_merge_databases_where_entry_did_not_exist() -> None:
new_database = {"c": 2}
previous_database = {"a": 0, "b": 1}
length_new_database = len(new_database)

merged_database = igdb_match_names.merge_databases(
new_database=new_database,
previous_database=previous_database,
)
assert len(merged_database) == len(previous_database) + len(new_database)
assert len(merged_database) == len(previous_database) + length_new_database
assert merged_database["a"] == previous_database["a"]
assert merged_database["b"] == previous_database["b"]
assert merged_database["c"] == new_database["c"]
Expand Down

0 comments on commit 6af51bd

Please sign in to comment.