fix: Thumbails have correct aspect ratio and reload if loaded while b…

[woelper]

…eing written

[Stoppedpuma]

The "Open thumb dir" button seems to freeze Oculante until the opened file manager window is closed.

[Stoppedpuma]

@woelper Another thing which you should probably check out before merging is #633.

[Stoppedpuma]

#633 Still happens around the actual image part:

The rounded corners on thumbnails also seem to have regressed on this PR. This seems to be caused by 61cbce7. The correct rounding value should be 6.

[woelper]

I am using the exact same rect, maybe this is because the image is snapped / aligned to whole pixels?

[woelper]

It seems rounding is not an option due to how the image is drawn. I can look at it, but it will likely not be possible.

[woelper]

#633 Still happens around the actual image part:

The rounded corners on thumbnails also seem to have regressed on this PR. This seems to be caused by 61cbce7. The correct rounding value should be 6.

Fortunately I was wrong. To me it looks good now, can you double check please?

[Stoppedpuma]

This looks good to me as well! Thanks for taking the time to look into the rounding as well as the issue at #633!

One thing which sticks out to me that isn't really too much of an issue is that the new hover brightness value makes basically every images look either too bright or kind of washed out, Was there a reason for this change outside of the thumbnails?

[woelper]

This looks good to me as well! Thanks for taking the time to look into the rounding as well as the issue at #633!

One thing which sticks out to me that isn't really too much of an issue is that the new hover brightness value makes basically every images look either too bright or kind of washed out, Was there a reason for this change outside of the thumbnails?

There wasn't a reason besides me thinking that the effect was too subtle. I reverted the change to 5.