fix(calico-3.29.yaml): Disable the calico-apiserver 3.29.2 when Validating Admission Policy checks until upstream tigrea operator adds the required rules #43188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ating Admission Policy checks until upstream tigrea operator adds the required rules Because we are using tigera-operator during image test we are reliant on tigera-operator setting up all the required rbac rules that are needed for calico-apiserver to run. Currently it does not [1] and this is a temporary solution until tigera/operator#3780 is resolved upstream with a new release of tigera-operator. This issue was highlighed in calico-apiserver 3.29.2 when Validating Admission Policy became enabled by default [2]. This patch disables the Validating Admission Policy in calico-apiserver until the issue is resolved. [1] https://github.com/tigera/operator/blob/ed26c42e1e232e9cc604a9a010d4ca9111b6f388/pkg/render/apiserver.go#L654C11-L654C28 [2] projectcalico/calico@8eacb02 Signed-off-by: philroche <phil.roche@chainguard.dev>
|
I have successfully tested this locally in locally built calico-* images. |
octo-sts
bot
added
the
bincapz/pass
|
Attempted automated remediation for the detected CVE @ #42678 |
|
Detected CVE should not block fixing the image build failures @ https://github.com/chainguard-dev/image-release-stats/issues/4507 |
OddBloke
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we are using tigera-operator during image test we are reliant on tigera-operator setting
up all the required rbac rules that are needed for calico-apiserver to run. Currently it does not [1] and
this is a temporary solution until tigera/operator#3780 is resolved upstream with a new
release of tigera-operator. This issue was highlighed in calico-apiserver 3.29.2 when Validating Admission Policy
became enabled by default [2]. This patch disables the Validating Admission Policy in calico-apiserver until
the issue is resolved.
[1] https://github.com/tigera/operator/blob/ed26c42e1e232e9cc604a9a010d4ca9111b6f388/pkg/render/apiserver.go#L654C11-L654C28
[2] projectcalico/calico@8eacb02
Signed-off-by: philroche phil.roche@chainguard.dev