Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support standard bullet styles #1409

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

cbess
Copy link
Contributor

@cbess cbess commented Feb 22, 2025

Reopening: #1354

  • Addressed each point in the above PR.
  • Added alternate ordered list style support per level

Similar to web browsers, draw different bullets at different levels.

To test:

  • Set the listIndentStyle to .standard
  • Create an ordered or unordered list
  • Add multiple levels to it
  • Notice the bullet style for level one is different than level two and three
  • Also, execute "Big Lists" demo, works as expected
Before After
old new
Screenshot 2025-02-22 at 4 53 29 PM Screenshot 2025-02-22 at 4 52 42 PM

  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

cbess added 9 commits March 28, 2022 19:47
similar to web browsers, draw different bullets at different levels
commit 4d0522d
Merge: 2b54f87 59d5090
Author: Gio Lodi <gio.lodi@automattic.com>
Date:   Thu Mar 9 12:08:36 2023 +1100

    Point `bash-cache` plugin to new `a8c-ci-toolkit` location (wordpress-mobile#1367)

commit 59d5090
Author: Gio Lodi <gio@mokacoding.com>
Date:   Mon Mar 6 21:10:15 2023 +1100

    Remove unused YAML anchor and fix indentation in pipeline

commit e0526bf
Author: Gio Lodi <gio@mokacoding.com>
Date:   Mon Mar 6 21:09:53 2023 +1100

    Point `bash-cache` plugin to new `a8c-ci-toolkit` location

    While I was at it, I also updated the version to the latest, 2.13.0.

    This was done via:

    ```
    find . -type f -name "*.yml" -exec sed -i '' 's/automattic\/bash-cache#[0-9.]\{1,\}/automattic\/a8c-ci-toolkit#2.13.0/g' {} +
    ```

commit 2b54f87
Merge: b7d8a70 d18d0a8
Author: Gio Lodi <giovanni.lodi42@gmail.com>
Date:   Thu Oct 20 16:59:18 2022 +1100

    Add `CHANGELOG.md` (wordpress-mobile#1365)

commit d18d0a8
Author: Gio Lodi <gio@mokacoding.com>
Date:   Thu Oct 20 15:18:16 2022 +1100

    Update `PULL_REQUEST_TEMPLATE.md` with note about `CHANGELOG.md`

commit 2c73ef5
Author: Gio Lodi <gio@mokacoding.com>
Date:   Thu Oct 20 14:32:38 2022 +1100

    Add changelog entry about changelog itself

commit 212ce2f
Author: Gio Lodi <gio@mokacoding.com>
Date:   Thu Oct 20 14:15:12 2022 +1100

    Update `CHANGELOG.md` with new format

commit b7d8a70
Merge: 91cf065 40afa55
Author: Gio Lodi <giovanni.lodi42@gmail.com>
Date:   Tue Oct 4 10:29:42 2022 +1100

    Tools upgrade: Ruby 2.7.4, bash-cache 2.8.0 (wordpress-mobile#1363)

commit 40afa55
Author: Gio Lodi <gio@mokacoding.com>
Date:   Mon Oct 3 20:00:33 2022 +1100

    Use `bash-cache` Buildkite plugin version 2.8.0

    This version includes a fix that removes the need to run
    `gem install bundler` before each step.

commit bd8840a
Author: Gio Lodi <gio@mokacoding.com>
Date:   Mon Oct 3 19:59:52 2022 +1100

    Use Ruby version 2.7.4

commit 91cf065
Merge: 9d8d9b8 1ce621c
Author: Diego Rey Mendez <diegoreymendez@users.noreply.github.com>
Date:   Wed Aug 10 15:07:41 2022 +0200

    Merge pull request wordpress-mobile#1353 from cbess/expose-indentation-actions

    Expose indentation operations

commit 9d8d9b8
Merge: b16c763 7eb60c7
Author: Tony Li <i@crazytony.li>
Date:   Mon Jul 25 11:11:13 2022 +1200

    Merge pull request wordpress-mobile#1359 from wordpress-mobile/remove/circle-ci

    Remove CircleCI

commit 7eb60c7
Author: Jeremy Massel <1123407+jkmassel@users.noreply.github.com>
Date:   Fri Jul 22 23:23:27 2022 -0600

    Trigger Build

commit f91511e
Author: Jeremy Massel <1123407+jkmassel@users.noreply.github.com>
Date:   Thu Jul 21 23:03:28 2022 -0600

    Remove CircleCI

commit 1ce621c
Author: C. Bess <cbess@users.noreply.github.com>
Date:   Sat Mar 26 12:31:51 2022 -0500

    cleanup whitespace

commit ed55d4a
Author: C. Bess <cbess@users.noreply.github.com>
Date:   Sat Mar 26 12:31:03 2022 -0500

    cleanup whitespace

commit 4561534
Author: C. Bess <cbess@users.noreply.github.com>
Date:   Sat Mar 26 12:01:30 2022 -0500

    expose indentation operations

    - make increase/decrease indentation actions visible
    - cleanup code
- support indent style option
- support html-style order list, using alphabets and roman numerals
- cleanup code
@cbess cbess marked this pull request as ready for review February 22, 2025 23:08
@cbess
Copy link
Contributor Author

cbess commented Feb 22, 2025

@twstokes it should be ready now :)

@cbess cbess changed the title RE: Support alternate bullet style per level Support standard bullet styles Feb 23, 2025
@twstokes
Copy link
Contributor

@twstokes it should be ready now :)

Sounds good @cbess! I'll aim to look at it soon.

@twstokes twstokes self-requested a review February 25, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants