Skip to content

Commit

Permalink
Revert "Refactor prototype_build_details_comment for FAD (#630) (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
iangmaia authored Feb 19, 2025
2 parents 9b130c7 + d7fc901 commit 8db36b1
Show file tree
Hide file tree
Showing 4 changed files with 566 additions and 487 deletions.
7 changes: 3 additions & 4 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@

### Breaking Changes

- The `prototype_build_details_comment` action now relies on the `lane_context` of `firebase_app_distribution` instead of the one from `appcenter_upload` for the implicit metadata and download URL to use in the comment.
This is in the context of us moving from App Center (which will be shut down in March 2025) to Firebase App Distribution as our primary mechanism to distribute prototype builds. [#630]
_None_

### New Features

Expand All @@ -19,7 +18,7 @@ _None_

### Internal Changes

- The library now uses immutable literals, via `# frozen_strings_literal: true`. This may result in runtime issues that we will address ASAP once discovered. [#626]
- The library now uses immutable literals, via `# frozen_strings_literal: true`. This may result in runtime issues that we will address ASAP once discovered [#626]

## 12.4.0

Expand All @@ -30,7 +29,7 @@ _None_

### Bug Fixes

- Remove period from "Update draft release notes..." commit message. [#622]
- Remove period from "Update draft release notes..." commit message [#622]

## 12.3.4

Expand Down
6 changes: 0 additions & 6 deletions MIGRATION.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,5 @@
# Migration Instructions for Major Releases

## From 12.x to 13.0.0

- The `prototype_build_details_comment` action have been updated to work with Firebase App Distribution instead of App Center [#630].
- If you were using the `prototype_build_details_comment` action in concert with the `appcenter_upload` action, you'll need to migrate to use `firebase_app_distribution` action instead, then adjust the parameters for `prototype_build_details_comment` accordingly (mostly removing the `appcenter_upload`-related ones like `app_center_org_name`).
- If you were using the `prototype_build_details_comment` action out of the context of App Center but with a `download_url` instead (e.g. Cloudfront URL), no update of the call site is needed.

## From 11.x to 12.0.0

- `android_current_branch_is_hotfix` no longer supports the `build_gradle_path` parameter. Convert the project to define `versionName` and `versionCode` in `version.properties` and call `android_current_branch_is_hotfix` with `version_properties_path`.
Expand Down
Loading

0 comments on commit 8db36b1

Please sign in to comment.