Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove period from "Update draft release notes..." commit message #622

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Remove period from "Update draft release notes..." commit message #622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6cc1374
Remove period from "Update draft release notes..." commit message
mokagio Dec 3, 2024
80a7a8f
Add changelog entry for '.' removal from commit title
mokagio Dec 3, 2024
72b0592
Update git-commit implementation to use fastlane actions
AliSoftware Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ _None_

### Bug Fixes

_None_
- Remove period from "Update draft release notes..." commit message [#622]

### Internal Changes

Expand Down
12 changes: 8 additions & 4 deletions ...tlane/plugin/wpmreleasetoolkit/actions/common/extract_release_notes_for_version_action.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ def self.run(params)
return if extracted_notes_file.nil?

extracted_notes_file.close
check_and_commit_extracted_notes_file(extracted_notes_file_path, version)
commit_extracted_notes_file(extracted_notes_file_path, version)
end

def self.extract_notes(release_notes_file_path, version)
Expand All @@ -39,9 +39,13 @@ def self.extract_notes(release_notes_file_path, version)
end
end

def self.check_and_commit_extracted_notes_file(file_path, version)
Action.sh("git add #{file_path}")
Action.sh("git diff-index --quiet HEAD || git commit -m \"Update draft release notes for #{version}.\"")
def self.commit_extracted_notes_file(file_path, version)
other_action.git_add(path: file_path)
other_action.git_commit(
path: file_path,
message: "Update draft release notes for #{version}",
allow_nothing_to_commit: true
)
end

def self.description
Expand Down
Loading