Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 13.0.0 into trunk #632

Closed
wants to merge 1 commit into from
Closed

Release 13.0.0 into trunk #632

wants to merge 1 commit into from

Conversation

iangmaia
Copy link
Contributor

Releasing new version 13.0.0.

What's Next

PR Author: Be sure to create and publish a GitHub Release pointing to trunk once this PR gets merged,
copy/pasting the following text as the GitHub Release's description:

### Breaking Changes

- The `prototype_build_details_comment` action now relies on the `lane_context` of `firebase_app_distribution` instead of the one from `appcenter_upload` for the implicit metadata and download URL to use in the comment.
  This is in the context of us moving from App Center (which will be shut down in March 2025) to Firebase App Distribution as our primary mechanism to distribute prototype builds. [#630]

### New Features

- The `ios_lint_localizations` action now accepts a `fail_on_strings_not_in_base_language` parameter (defaulting to `true`) to control whether to report violations when finding strings in translations that are not present in the base language. [#631]

### Internal Changes

- The library now uses immutable literals, via `# frozen_strings_literal: true`. This may result in runtime issues that we will address ASAP once discovered. [#626]


@iangmaia iangmaia added the Releases Release related stuff label Feb 19, 2025
@iangmaia iangmaia requested a review from a team February 19, 2025 10:25
@iangmaia iangmaia self-assigned this Feb 19, 2025
@AliSoftware
Copy link
Contributor

So we're going with a major version that includes my prototype_build_details_comment after all, even if that means we'll have to wait until the FAD migration is ready to be adopted for repos (especially WCiOS) to also be able to benefit from ios_lint_localizations flexibility to not-crash on unknown translations?

As opposed to reverting my prototype_build_details_comment PR, make a 12.5.0 minor version, then restoring my prototype_build_details_comment PR to be ready for next major?

I'm ok with this if that was the intent and we consider that this adoption of ios_lint_localizations can wait before being adopted in WCiOS; but I just wanted to check what the plan was (especially regarding pdnsEh-210-p2)

@iangmaia
Copy link
Contributor Author

So we're going with a major version that includes my prototype_build_details_comment after all, even if that means we'll have to wait until the FAD migration is ready to be adopted for repos (especially WCiOS) to also be able to benefit from ios_lint_localizations flexibility to not-crash on unknown translations?

As opposed to reverting my prototype_build_details_comment PR, make a 12.5.0 minor version, then restoring my prototype_build_details_comment PR to be ready for next major?

I'm ok with this if that was the intent and we consider that this adoption of ios_lint_localizations can wait before being adopted in WCiOS; but I just wanted to check what the plan was (especially regarding pdnsEh-210-p2)

Tbh I keep going back and for with this 😓 -- part of me says to just move forward and have WCiOS ready for the FAD migration, which should be soon anyway, and avoid the revert and intermediate releases; part of me wants to be on the more conservative side, play safe and adopt ios_lint_localizations sooner -- just by writing this now I'm thinking of following that route instead, so we can close this issue sooner, which is independent of the FAD, leave the FAD matter to be handled separately.
Then next steps would be to 1) close this PR, 2) create a PR reverting #630 and 3) creating the 12.5.0 release PR.

@AliSoftware
Copy link
Contributor

just by writing this now I'm thinking of following that route instead, so we can close this issue sooner, which is independent of the FAD, leave the FAD matter to be handled separately.

Let's do this 👍

@iangmaia iangmaia closed this Feb 19, 2025
@iangmaia iangmaia deleted the release/13.0.0 branch February 19, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Releases Release related stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants