-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overlay not full screen in some devices #114
Comments
I had this problem too, to solve it you need to download the TourGuide lib from here https://github.com/worker8/TourGuide/releases/tag/v1.0.17-SNAPSHOT and integrate it in your app, to be able to modify the lib code.
It allows to get the "real" resolution of the device, including the soft buttons area if any. Finally, each time TourGuide lib calls Solved! :) |
not working,can you show the sample code? |
"Can you show the sample code please?" I wrote above the method to get the real screen resolution, including the soft buttons area. |
got it! |
You're welcome :) |
Thank you |
Another way to deal with this issue, is to replace the official Gradle dependency of this project, which I had it like this:
And replace it with the patched version from hieuseesaa:
This way, you'll basically download the dependency from the Git fork of hieuseesaa (to the very commit that deals with this, so if the fork of hieuseesaa changes, it won't affect anything else). We wouldn't have to do this if the maintainer of this wonderful Android library would accept the pull request from hieuseesaa. |
@carlos-mg89 |
Overlay leaves some space at the bottom in devices with onscreen buttons in navigation bar. It is fine with device with physical button.
The text was updated successfully, but these errors were encountered: