Units: Measures are a bit weird to create

[qwertychouskie]

The current way to create a distance in inches (from https://docs.wpilib.org/en/latest/docs/software/basic-programming/java-units.html):

Distance wheelDiameter = Inches.of(6);

"Inches of 6" doesn't read naturally, making this code a bit awkward. Changing of to from was suggested, but although this is slightly better, it's still a bit weird.

Something like one of these would feel more natural:

Distance wheelDiameter = Unit.Inches(6);     // Unit would contain all valid types of units
Distance wheelDiameter = Distance.Inches(6); // Distance would contain valid types of distance units

This way, you can also use var, since the created type will be pretty clear, and you won't have to remember which exact class contains the unit you want:

var wheelDiameter = Unit.Inches(6);        // wheelDiameter will be of the type Distance
var kMaxSpeed = Unit.MetersPerSecond(2.5); // wheelDiameter will be of the type LinearVelocity

[PeterJohnson]

The proposed approach isn’t naturally extensible to user-created units though, as users can’t inject new unit static functions into the Units class.

[qwertychouskie]

The proposed approach isn’t naturally extensible to user-created units though, as users can’t inject new unit static functions into the Units class.

You could create a MyUnits class that extends Unit and implements your custom units. Alternatively, you could just use the old syntax anywhere you create custom units, there's no reason that the approaches can't co-exist. That said, in what circumstances would custom units be needed in the first place? There are only so many units that exist in the world, unless I'm missing something.