Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wpimath] Fix up order and docs for Feedforward gain setters #7788

Merged
merged 5 commits into from
Feb 14, 2025

Conversation

PeterJohnson
Copy link
Member

Fixes #7785.
Fixes #7786.

@PeterJohnson PeterJohnson requested a review from a team as a code owner February 14, 2025 05:31
@github-actions github-actions bot added the component: wpimath Math library label Feb 14, 2025
PeterJohnson and others added 2 commits February 13, 2025 22:50
…ward.java

Co-authored-by: Tyler Veness <calcmogul@gmail.com>
…edforward.java

Co-authored-by: Tyler Veness <calcmogul@gmail.com>
calcmogul
calcmogul previously approved these changes Feb 14, 2025
@PeterJohnson PeterJohnson merged commit 7e6077c into wpilibsuite:main Feb 14, 2025
33 of 38 checks passed
@PeterJohnson PeterJohnson deleted the fix-feedforward-comments branch February 14, 2025 07:20
katzuv pushed a commit to katzuv/allwpilib that referenced this pull request Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feedforward gain setters are out of order C++ feedforward gain setters have incorrect docs
2 participants