Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear token cache when hashing is disabled #2698

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

HasiniSama
Copy link
Contributor

@HasiniSama HasiniSama commented Feb 7, 2025

Proposed changes in this pull request

$subject

This fix will hash the access token before sending it for cache clearance when hashing is disabled.

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.72%. Comparing base (9ef99cc) to head (5097dee).
Report is 52 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2698      +/-   ##
============================================
- Coverage     56.30%   55.72%   -0.58%     
- Complexity     8595     8807     +212     
============================================
  Files           654      654              
  Lines         49393    50839    +1446     
  Branches       9950    10470     +520     
============================================
+ Hits          27811    28331     +520     
- Misses        17621    18474     +853     
- Partials       3961     4034      +73     
Flag Coverage Δ
unit 39.83% <100.00%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HasiniSama HasiniSama force-pushed the fix-secret-regenerate-cache-issue branch from ed1de7a to 5097dee Compare February 11, 2025 04:14
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/13363249108

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/13363249108
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/13490656180

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/13490656180
Status: failure

@ThaminduDilshan
Copy link
Contributor

@HasiniSama let's analyze integration test failures and update the code/ tests accordingly. Converting the PR to a draft until the tests are fixed

@ThaminduDilshan ThaminduDilshan marked this pull request as draft February 24, 2025 06:33
@JeethJJ
Copy link
Contributor

JeethJJ commented Feb 26, 2025

Hi @HasiniSama,

⚠️ Notice: This PR has been open for a while. To keep the repository clean and up-to-date, this PR will be closed within the next two weeks if there is no further activity.

Please take one of the following actions:

  • Merge the PR if it is ready.
  • Close the PR if it is no longer relevant.
  • Leave a comment explaining why it should remain open and provide an update on its progress.

Your prompt attention to this matter is greatly appreciated. Thank you for your understanding and collaboration! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants