Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set requestBinding for refresh token grant. #2737

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Yasasr1
Copy link
Contributor

@Yasasr1 Yasasr1 commented Feb 26, 2025

Purpose

Sets the requestBinding type to the tokens issued from the refresh token grant when the renew_token_without_revoking_existing config is enabled and refresh token grant is set as an allowed grant type

Related issue

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 56.47%. Comparing base (45484e8) to head (3f020ab).
Report is 25 commits behind head on master.

Files with missing lines Patch % Lines
...uth2/token/handlers/grant/RefreshGrantHandler.java 0.00% 7 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2737      +/-   ##
============================================
- Coverage     56.92%   56.47%   -0.45%     
- Complexity     8570     8691     +121     
============================================
  Files           654      654              
  Lines         48442    49805    +1363     
  Branches      10263    10646     +383     
============================================
+ Hits          27575    28128     +553     
- Misses        16959    17649     +690     
- Partials       3908     4028     +120     
Flag Coverage Δ
unit 39.97% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/13585826796

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/13585826796
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/13585826796

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants