Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve DialectConfigParser to build the final server supported claims set #6535

Merged
merged 4 commits into from
Feb 19, 2025

Conversation

amanda-ariyaratne
Copy link
Contributor

@amanda-ariyaratne amanda-ariyaratne commented Feb 19, 2025

Proposed changes in this pull request

In this PR we extend the existing dialect parser to build and get the final server supported claims set.

Related Issue

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 47.16%. Comparing base (309084e) to head (4466237).
Report is 18 commits behind head on master.

Files with missing lines Patch % Lines
...tadata/mgt/ClaimMetadataManagementServiceImpl.java 11.11% 7 Missing and 1 partial ⚠️
...y/claim/metadata/mgt/util/DialectConfigParser.java 60.00% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6535      +/-   ##
============================================
- Coverage     47.17%   47.16%   -0.01%     
- Complexity    15372    15376       +4     
============================================
  Files          1751     1751              
  Lines        105784   105805      +21     
  Branches      19658    19663       +5     
============================================
+ Hits          49903    49907       +4     
- Misses        48821    48834      +13     
- Partials       7060     7064       +4     
Flag Coverage Δ
unit 30.55% <40.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sadilchamishka
sadilchamishka previously approved these changes Feb 19, 2025
sadilchamishka
sadilchamishka previously approved these changes Feb 19, 2025
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/13413141360

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/13413141360
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/13413141360

@amanda-ariyaratne amanda-ariyaratne merged commit 365c8ed into wso2:master Feb 19, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants