Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove thread local property in claim mgt service after using #6539

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

amanda-ariyaratne
Copy link
Contributor

Proposed changes in this pull request

$subject

Related Issue

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/13420052197

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 47.18%. Comparing base (4466237) to head (684ebaa).
Report is 28 commits behind head on master.

Files with missing lines Patch % Lines
...tadata/mgt/ClaimMetadataManagementServiceImpl.java 14.28% 5 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (14.28%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6539      +/-   ##
============================================
+ Coverage     47.16%   47.18%   +0.01%     
- Complexity    15376    15379       +3     
============================================
  Files          1751     1754       +3     
  Lines        105805   105871      +66     
  Branches      19663    19666       +3     
============================================
+ Hits          49907    49953      +46     
- Misses        48834    48853      +19     
- Partials       7064     7065       +1     
Flag Coverage Δ
unit 30.55% <14.28%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/13420052197
Status: failure

@ashensw
Copy link
Contributor

ashensw commented Feb 20, 2025

PR builder completed Link: https://github.com/wso2/product-is/actions/runs/13420052197 Status: failure

The integration test failure is a known intermittently failing test case tracked in wso2/product-is#23094

@ashensw ashensw merged commit 77bc0e0 into wso2:master Feb 20, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants