-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sub org role business API scope persist issue #6541
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (23.88%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #6541 +/- ##
============================================
+ Coverage 45.94% 46.00% +0.06%
- Complexity 14870 15587 +717
============================================
Files 1737 1834 +97
Lines 107400 111478 +4078
Branches 19890 20622 +732
============================================
+ Hits 49346 51288 +1942
- Misses 51026 52873 +1847
- Partials 7028 7317 +289
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
...gt/src/main/java/org/wso2/carbon/identity/application/mgt/dao/impl/AuthorizedAPIDAOImpl.java
Outdated
Show resolved
Hide resolved
...gt/src/main/java/org/wso2/carbon/identity/application/mgt/dao/impl/AuthorizedAPIDAOImpl.java
Outdated
Show resolved
Hide resolved
...gt/src/main/java/org/wso2/carbon/identity/application/mgt/dao/impl/AuthorizedAPIDAOImpl.java
Outdated
Show resolved
Hide resolved
...gt/src/main/java/org/wso2/carbon/identity/application/mgt/dao/impl/AuthorizedAPIDAOImpl.java
Outdated
Show resolved
Hide resolved
...gt/src/main/java/org/wso2/carbon/identity/application/mgt/dao/impl/AuthorizedAPIDAOImpl.java
Outdated
Show resolved
Hide resolved
...gt/src/main/java/org/wso2/carbon/identity/application/mgt/dao/impl/AuthorizedAPIDAOImpl.java
Outdated
Show resolved
Hide resolved
PR builder started |
|
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/13441762766
Proposed changes in this pull request
Currently persisting role to scope assignments is not working for sub org roles since it tries to get the scope data using the sub org tenant domain. This PR fixes that issue by resolving the primary tenant domain where the scopes are persisted.
In addition to the above issue, business API scope retrieval and authorization issues are also fixed this PR.
Issue - wso2/product-is#23190