Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sub org role business API scope persist issue #6541

Merged
merged 4 commits into from
Feb 20, 2025

Conversation

SujanSanjula96
Copy link
Contributor

@SujanSanjula96 SujanSanjula96 commented Feb 20, 2025

Proposed changes in this pull request

Currently persisting role to scope assignments is not working for sub org roles since it tries to get the scope data using the sub org tenant domain. This PR fixes that issue by resolving the primary tenant domain where the scopes are persisted.
In addition to the above issue, business API scope retrieval and authorization issues are also fixed this PR.

Issue - wso2/product-is#23190

AnuradhaSK
AnuradhaSK previously approved these changes Feb 20, 2025
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 23.88060% with 51 lines in your changes missing coverage. Please review.

Project coverage is 46.00%. Comparing base (fc342ef) to head (a9977a9).
Report is 199 commits behind head on master.

Files with missing lines Patch % Lines
...rce/mgt/dao/impl/APIResourceManagementDAOImpl.java 28.57% 23 Missing and 2 partials ⚠️
...application/mgt/dao/impl/AuthorizedAPIDAOImpl.java 20.00% 13 Missing and 3 partials ⚠️
...bon/identity/role/v2/mgt/core/dao/RoleDAOImpl.java 16.66% 9 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (23.88%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6541      +/-   ##
============================================
+ Coverage     45.94%   46.00%   +0.06%     
- Complexity    14870    15587     +717     
============================================
  Files          1737     1834      +97     
  Lines        107400   111478    +4078     
  Branches      19890    20622     +732     
============================================
+ Hits          49346    51288    +1942     
- Misses        51026    52873    +1847     
- Partials       7028     7317     +289     
Flag Coverage Δ
unit 30.58% <23.88%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/13441762766

Copy link

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/13441762766
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/13441762766

@AnuradhaSK AnuradhaSK merged commit 87acebc into wso2:master Feb 20, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants