Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache empty action list when no action is configured #6560

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

ashanthamara
Copy link
Contributor

@ashanthamara ashanthamara commented Feb 25, 2025

Proposed changes in this pull request

  • Previously when no actions are configured it didn't cache the empty action list in the cache.
  • Due to that reason, it requires i/o operations to fetch actions from the DB everytime.
  • Caching the empty list will prevent above overhead.

Related Issue

@ashanthamara ashanthamara marked this pull request as ready for review February 25, 2025 08:41
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/13517173276

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.26%. Comparing base (d772b63) to head (3a74147).
Report is 6 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6560      +/-   ##
============================================
- Coverage     47.30%   47.26%   -0.04%     
+ Complexity    15408    15386      -22     
============================================
  Files          1751     1751              
  Lines        105682   105682              
  Branches      19960    19960              
============================================
- Hits          49990    49949      -41     
- Misses        48621    48666      +45     
+ Partials       7071     7067       -4     
Flag Coverage Δ
unit 30.58% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/13517173276
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/13527107559

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/13527107559
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/13527107559

@ashanthamara ashanthamara merged commit 8f4c3d9 into wso2:master Feb 27, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants