Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip RAR Feature Check When Authorization Details Are Empty #6565

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Skip RAR Feature Check When Authorization Details Are Empty #6565

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ...n/java/org/wso2/carbon/identity/api/resource/mgt/AuthorizationDetailsTypeManagerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,9 @@ public List<AuthorizationDetailsType> addAuthorizationDetailsTypes(
String apiId, List<AuthorizationDetailsType> authorizationDetailsTypes, String tenantDomain)
throws APIResourceMgtException {

if (CollectionUtils.isEmpty(authorizationDetailsTypes)) {
return Collections.emptyList();
}
AuthorizationDetailsTypesUtil.assertRichAuthorizationRequestsEnabled();
return this.authorizationDetailsTypeMgtDAO.addAuthorizationDetailsTypes(apiId, authorizationDetailsTypes,
IdentityTenantUtil.getTenantId(tenantDomain));
Expand Down Expand Up @@ -168,6 +171,10 @@ public void updateAuthorizationDetailsTypes(String apiId, List<String> removedAu
List<AuthorizationDetailsType> addedAuthorizationDetailsTypes,
String tenantDomain) throws APIResourceMgtException {

if (CollectionUtils.isEmpty(removedAuthorizationDetailsTypes) &&
CollectionUtils.isEmpty(addedAuthorizationDetailsTypes)) {
return;
}
AuthorizationDetailsTypesUtil.assertRichAuthorizationRequestsEnabled();
this.authorizationDetailsTypeMgtDAO.updateAuthorizationDetailsTypes(apiId, removedAuthorizationDetailsTypes,
addedAuthorizationDetailsTypes, IdentityTenantUtil.getTenantId(tenantDomain));
Expand All @@ -180,6 +187,9 @@ public void updateAuthorizationDetailsTypes(String apiId, List<String> removedAu
public void updateAuthorizationDetailsType(String apiId, AuthorizationDetailsType authorizationDetailsType,
String tenantDomain) throws APIResourceMgtException {

if (authorizationDetailsType == null) {
return;
}
AuthorizationDetailsTypesUtil.assertRichAuthorizationRequestsEnabled();
this.authorizationDetailsTypeMgtDAO.updateAuthorizationDetailsTypes(apiId,
Collections.singletonList(authorizationDetailsType), IdentityTenantUtil.getTenantId(tenantDomain));
Expand Down