-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor isOrganization check to service layer when fetching API resource by ID #6566
Refactor isOrganization check to service layer when fetching API resource by ID #6566
Conversation
261734a
to
3bb80ff
Compare
.../src/main/java/org/wso2/carbon/identity/api/resource/mgt/util/APIResourceManagementUtil.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/wso2/carbon/identity/api/resource/mgt/util/APIResourceManagementUtil.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/wso2/carbon/identity/api/resource/mgt/util/APIResourceManagementUtil.java
Outdated
Show resolved
Hide resolved
...urce.mgt/src/main/java/org/wso2/carbon/identity/api/resource/mgt/APIResourceManagerImpl.java
Show resolved
Hide resolved
3bb80ff
to
c61fffa
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6566 +/- ##
============================================
+ Coverage 47.26% 47.28% +0.02%
- Complexity 15408 15464 +56
============================================
Files 1751 1757 +6
Lines 105718 106136 +418
Branches 19961 20069 +108
============================================
+ Hits 49965 50191 +226
- Misses 48681 48851 +170
- Partials 7072 7094 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/13585604265
7b5a3a3
to
3275518
Compare
|
Proposed changes in this pull request
Fixes: wso2/product-is#23297
Refactor sub-organization logic check to the Service layer, before CacheBacked DAO layer, when fetching API resource by ID.
This ensures the cache only contains the root organization tenant domain cache entry.
Tested outflows:
Merged After
After: wso2/identity-organization-management-core#171