golanci-lint not happy anymore so CI not passing #1721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

toby-bro opened this issue Mar 30, 2025 · 0 comments · May be fixed by #1720

toby-bro commented Mar 30, 2025

What's broken?

golanci was broken as rules have changed,

$ golangci-lint run --color=always ./... --timeout=10m
WARN [lintersdb] The name "vet" is deprecated. The linter has been renamed to: govet. 
modules/gitter/widget.go:71:5: S1009: should omit nil check; len() for nil slices is defined as zero (gosimple)
        if widget.messages == nil || len(widget.messages) == 0 {
           ^

reference of the rule

toby-bro linked a pull request

that will close this issue

fix: golangci lint was not passing anymore #1720

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment