Skip to content

fix: golangci lint was not passing anymore #1720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: golangci lint was not passing anymore #1720

wants to merge 1 commit into from
+1 −1

Conversation

toby-bro
Copy link

@toby-bro toby-bro commented Mar 29, 2025 •
edited
Loading

This PR #1706 fixes the issue too but also did lots of things so opening a simpler PR just for fixing the CI

before

❯ golangci-lint run --color=always ./... --timeout=10m
WARN [lintersdb] The name "vet" is deprecated. The linter has been renamed to: govet. 
modules/gitter/widget.go:71:5: S1009: should omit nil check; len() for nil slices is defined as zero (gosimple)
        if widget.messages == nil || len(widget.messages) == 0 {
           ^

now it passes the ci

edit :
fixes #1721

This was referenced Mar 29, 2025
Open
Open
@toby-bro toby-bro changed the title fix: golangci lint not passing anymore fix: golangci lint was not passing anymore Mar 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

golanci-lint not happy anymore so CI not passing
1 participant
@toby-bro