Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to remove ports #2

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

nwoeanhinnogaehr
Copy link

The client cannot be running when this is done, because then we may erase from the middle of m{Input,Output}Ports while jackToClassAudioCallback is getting the ports. There's probably a way to defer erasing the port so this can be worked around, but does anyone need to remove ports from a running client anyways?

@x37v
Copy link
Owner

x37v commented Jan 12, 2017

oh nice, i guess I missed the notification on this one, I'll take a look at it when I have some time and then merge it in. Thanks!

I could see needing to remove from a running client.. say you create then erase an aux bus channel or something?

@x37v x37v self-assigned this Jan 12, 2017
@nwoeanhinnogaehr
Copy link
Author

I also realize now that this doesn't update either the swig interface or the blocking API.

I'm going to put some more thought into how it could be made to work with running clients in the next few days because it became a bit annoying having to reconnect all ports after removing a few.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants