CP-52708: Avoid making Unix read/write calls for internal API calls: … #6178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psafont
reviewed
Dec 13, 2024
edwintorok
force-pushed
the
pr/CP-52708
branch
from
f5d6094 to
5e1d2db
Compare
edwintorok
force-pushed
the
pr/CP-52708
branch
from
5e1d2db to
78a86c6
Compare
psafont
reviewed
Feb 5, 2025
psafont
approved these changes
Feb 5, 2025
This will enable short-circuiting internal API calls. When the FD is missing mark the call as Internal. Signed-off-by: Edwin Török <edwin.torok@cloud.com>
…forward the API call directly like we do with the CLI for calls to the coordinator when we are the coordinator Signed-off-by: Edwin Török <edwin.torok@cloud.com>
edwintorok
force-pushed
the
pr/CP-52708
branch
from
78a86c6 to
4d275d6
Compare
auto-merge was automatically disabled
February 6, 2025 18:49
Pull request was converted to draft
|
Moving back to draft, no feature flag on this one. |
|
This seems quite safe and contained to merge, are you sure this should still be a draft? |
lindig
approved these changes
Jun 18, 2025
|
Unrelated: why is a parameter that is used everywhere using a long and unusual name like |
|
@lindig I think you need a time machine set to 2006 in order to answer that question. |
|
I can try a quick grep + sed if it makes you happy, I would be painful to rebase all work being done though 😬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…forward the API call directly like we do with the CLI for calls to the coordinator when we are the coordinator
We might want to check that tracing still works with this, e.g. we might have to create a new span.
This avoids a lot of needless internal serialization, and a similar mechanism is already used by the CLI.