CP-54441 Adapt interface ordering in xe-reset-networking #6544
+20
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If interface-rename script doesn't exist, networkd will - handle the interfaces sorting - write inventory when first boot So, when interface-rename doesn't exist, xe-reset-networking should: - NOT call interface-rename script - Delete MANAGEMENT_INTERFACE value in inventory. BTW, the current bridge name conversion method rely on hardcode 'eth' which is correct only when interface-rename script exists. Signed-off-by: Changlei Li <changlei.li@cloud.com>
|
networkd write management_interface here https://github.com/xapi-project/xen-api/blob/feature/host-network-device-ordering/ocaml/networkd/lib/network_config.ml#L181-L812 |
changlei-li
force-pushed
the
private/changleli/CP-54441
branch
from
8b27ba1 to
8fff11c
Compare
On XS 8, `service xapi stop` redirect to `systemctl`. On XS 9, `service` is not supported. So use `systemctl` to stop xapi service. Signed-off-by: Changlei Li <changlei.li@cloud.com>
changlei-li
force-pushed
the
private/changleli/CP-54441
branch
from
8fff11c to
33e349f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If interface-rename script doesn't exist, networkd will
So, when interface-rename doesn't exist, xe-reset-networking should:
BTW, the current bridge name conversion method rely on hardcode 'eth' which is correct only when interface-rename script exists.