-
Notifications
You must be signed in to change notification settings - Fork 20
Start up error handling #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
0ac9276
https://github.com/xch-dev/sage/issues/331
dkackman 1b34209
allow recovery from migration error
dkackman 38592e3
show login errors
dkackman 80f53bf
log login errors
dkackman 874532c
take switch_wallet out of sage initialization and make it part of the…
dkackman dc31162
Merge branch 'main' into startup-error-handling
dkackman 105da16
Merge branch 'main' into startup-error-handling
dkackman 3c2abfb
Merge branch 'main' into startup-error-handling
dkackman 00b6696
call switch_wallet when starting the rpc server
dkackman d383246
Merge branch 'main' into startup-error-handling
dkackman 76416c3
capture errors during login, display the actual error (not the auth e…
dkackman 96b9114
Merge branch 'main' into startup-error-handling
dkackman d5962ec
prettier
dkackman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,5 +9,6 @@ pub enum ErrorKind { | |
NotFound, | ||
Unauthorized, | ||
Internal, | ||
DatabaseMigration, | ||
Nfc, | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,24 +1,40 @@ | ||
import { commands } from '@/bindings'; | ||
import { useCallback, useEffect, useState } from 'react'; | ||
import { useErrors } from './useErrors'; | ||
import { logoutAndUpdateState } from '@/state'; | ||
|
||
export default function useInitialization() { | ||
const { addError } = useErrors(); | ||
|
||
const [initialized, setInitialized] = useState(false); | ||
|
||
const initialize = useCallback(async () => { | ||
commands | ||
.initialize() | ||
.then(() => setInitialized(true)) | ||
.catch(addError); | ||
const onInitialize = useCallback(async () => { | ||
try { | ||
await commands.initialize(); | ||
setInitialized(true); | ||
await commands.switchWallet(); | ||
} catch (error: any) { | ||
// Always add the error to be displayed | ||
addError(error); | ||
|
||
// Check if this is a database migration, which is recoverable | ||
if (error.kind === 'database_migration') { | ||
try { | ||
await logoutAndUpdateState(); | ||
} catch (logoutError) { | ||
console.error('Error during logout:', logoutError); | ||
} | ||
} else { | ||
console.error('Unrecoverable initialization error', error); | ||
} | ||
} | ||
}, [addError]); | ||
|
||
useEffect(() => { | ||
if (!initialized) { | ||
initialize(); | ||
onInitialize(); | ||
} | ||
}, [initialized, initialize]); | ||
}, [initialized, onInitialize]); | ||
|
||
return initialized; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.