Skip to content

Commit

Permalink
[Search Connectors] Remove menu next to 'New Connector' (elastic#211600)
Browse files Browse the repository at this point in the history
## Summary

With the removal of agentless connectors, 9.0 won't have Elastic-managed
connectors, so there's no need for a menu drop down.

### Closes elastic/search-team#9315

### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

- [ ] [See some risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
- [ ] ...

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
  • Loading branch information
3 people authored Feb 19, 2025
1 parent 58cea84 commit 70471c9
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 78 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -16089,10 +16089,7 @@
"xpack.enterpriseSearch.connectors.connectorStats.p.DocumentsLabel": "{documentAmount} documents",
"xpack.enterpriseSearch.connectors.connectorStats.pipelinesTitle": "Pipelines",
"xpack.enterpriseSearch.connectors.connectorStats.seeDocumentsTextLabel": "Voir les documents",
"xpack.enterpriseSearch.connectors.more.ariaLabel": "Plus d'options",
"xpack.enterpriseSearch.connectors.newConnectorButtonLabel": "Nouveau connecteur",
"xpack.enterpriseSearch.connectors.newConnectorsClientButtonLabel": "Nouveau connecteur autogéré",
"xpack.enterpriseSearch.connectors.newNativeConnectorButtonLabel": "Nouveau connecteur géré par Elastic",
"xpack.enterpriseSearch.connectors.title": "Connecteurs Elasticsearch",
"xpack.enterpriseSearch.connectorsTable.euiSearchBar.filterConnectorsLabel": "Filtrer les connecteurs",
"xpack.enterpriseSearch.connectorsTable.euiSearchBar.filterConnectorsPlaceholder": "Filtrer les connecteurs",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15951,10 +15951,7 @@
"xpack.enterpriseSearch.connectors.connectorStats.p.DocumentsLabel": "{documentAmount}ドキュメント",
"xpack.enterpriseSearch.connectors.connectorStats.pipelinesTitle": "パイプライン",
"xpack.enterpriseSearch.connectors.connectorStats.seeDocumentsTextLabel": "ドキュメントを表示",
"xpack.enterpriseSearch.connectors.more.ariaLabel": "その他のオプション",
"xpack.enterpriseSearch.connectors.newConnectorButtonLabel": "新しいコネクター",
"xpack.enterpriseSearch.connectors.newConnectorsClientButtonLabel": "新しいセルフマネージドコネクター",
"xpack.enterpriseSearch.connectors.newNativeConnectorButtonLabel": "新しいElasticマネージドコネクター",
"xpack.enterpriseSearch.connectors.title": "Elasticsearchコネクター",
"xpack.enterpriseSearch.connectorsTable.euiSearchBar.filterConnectorsLabel": "コネクターをフィルター",
"xpack.enterpriseSearch.connectorsTable.euiSearchBar.filterConnectorsPlaceholder": "コネクターをフィルター",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15677,10 +15677,7 @@
"xpack.enterpriseSearch.connectors.connectorStats.p.DocumentsLabel": "{documentAmount} 个文档",
"xpack.enterpriseSearch.connectors.connectorStats.pipelinesTitle": "管道",
"xpack.enterpriseSearch.connectors.connectorStats.seeDocumentsTextLabel": "查看文档",
"xpack.enterpriseSearch.connectors.more.ariaLabel": "更多选项",
"xpack.enterpriseSearch.connectors.newConnectorButtonLabel": "新连接器",
"xpack.enterpriseSearch.connectors.newConnectorsClientButtonLabel": "全新自管型连接器",
"xpack.enterpriseSearch.connectors.newNativeConnectorButtonLabel": "全新 Elastic 托管连接器",
"xpack.enterpriseSearch.connectors.title": "Elasticsearch 连接器",
"xpack.enterpriseSearch.connectorsTable.euiSearchBar.filterConnectorsLabel": "筛选连接器",
"xpack.enterpriseSearch.connectorsTable.euiSearchBar.filterConnectorsPlaceholder": "筛选连接器",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,9 @@ import { useActions, useValues } from 'kea';

import {
EuiButton,
EuiButtonIcon,
EuiContextMenuItem,
EuiContextMenuPanel,
EuiFlexGroup,
EuiFlexItem,
EuiLink,
EuiPopover,
EuiSearchBar,
EuiSpacer,
EuiText,
Expand All @@ -30,11 +26,7 @@ import { FormattedMessage } from '@kbn/i18n-react';
import { LEARN_MORE_LINK } from '../../../shared/constants';
import { KibanaLogic } from '../../../shared/kibana';
import { handlePageChange } from '../../../shared/table_pagination';
import {
NEW_INDEX_SELECT_CONNECTOR_CLIENTS_PATH,
NEW_INDEX_SELECT_CONNECTOR_NATIVE_PATH,
NEW_INDEX_SELECT_CONNECTOR_PATH,
} from '../../routes';
import { NEW_INDEX_SELECT_CONNECTOR_PATH } from '../../routes';
import { EnterpriseSearchContentPageTemplate } from '../layout';

import { DefaultSettingsFlyout } from '../settings/default_settings_flyout';
Expand Down Expand Up @@ -68,7 +60,6 @@ export const Connectors: React.FC<ConnectorsProps> = ({ isCrawler, isCrawlerSelf
useActions(ConnectorsLogic);
const { data, isLoading, searchParams, isEmpty, connectors } = useValues(ConnectorsLogic);
const [searchQuery, setSearchValue] = useState('');
const [showMoreOptionsPopover, setShowMoreOptionsPopover] = useState<boolean>(false);
const [showDefaultSettingsFlyout, setShowDefaultSettingsFlyout] = useState<boolean>(false);
const { productFeatures } = useValues(KibanaLogic);

Expand Down Expand Up @@ -147,65 +138,6 @@ export const Connectors: React.FC<ConnectorsProps> = ({ isCrawler, isCrawlerSelf
/>
</EuiButton>
</EuiFlexItem>
<EuiFlexItem>
<EuiPopover
isOpen={showMoreOptionsPopover}
closePopover={() => setShowMoreOptionsPopover(false)}
button={
<EuiButtonIcon
data-test-subj="entSearchContent-connectors-newConnector-moreOptionsButton"
data-telemetry-id="entSearchContent-connectors-newConnector-moreOptionsButton"
color="primary"
display="fill"
size="m"
iconType="boxesVertical"
aria-label={i18n.translate(
'xpack.enterpriseSearch.connectors.more.ariaLabel',
{ defaultMessage: 'More options' }
)}
onClick={() => setShowMoreOptionsPopover(!showMoreOptionsPopover)}
/>
}
>
<EuiContextMenuPanel
size="s"
items={[
<EuiContextMenuItem
size="s"
key="newConnectorNative"
onClick={() => {
KibanaLogic.values.navigateToUrl(
NEW_INDEX_SELECT_CONNECTOR_NATIVE_PATH
);
}}
icon="plusInCircle"
>
{i18n.translate(
'xpack.enterpriseSearch.connectors.newNativeConnectorButtonLabel',
{
defaultMessage: 'New Elastic managed Connector',
}
)}
</EuiContextMenuItem>,
<EuiContextMenuItem
size="s"
key="newConnectorClient"
icon="plusInCircle"
onClick={() => {
KibanaLogic.values.navigateToUrl(
NEW_INDEX_SELECT_CONNECTOR_CLIENTS_PATH
);
}}
>
{i18n.translate(
'xpack.enterpriseSearch.connectors.newConnectorsClientButtonLabel',
{ defaultMessage: 'New Self-managed Connector' }
)}
</EuiContextMenuItem>,
]}
/>
</EuiPopover>
</EuiFlexItem>
</EuiFlexGroup>,
...(productFeatures.hasDefaultIngestPipeline
? [
Expand Down

0 comments on commit 70471c9

Please sign in to comment.