-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Dealing with the various version of the Febus Format #19
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ClaudioStrumia Could you test that branch on real data to validate it. Also could you check the by default trimming and try to propose something that should work in most cases.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #19 +/- ##
==========================================
- Coverage 85.89% 85.31% -0.59%
==========================================
Files 28 28
Lines 3312 3336 +24
==========================================
+ Hits 2845 2846 +1
- Misses 467 490 +23 ☔ View full report in Codecov by Sentry. |
Because the Febus format version history is undocumented, we encorage to manually set the trimming and timing strategy when reading Febus file.
Add:
overlaps
andoffset
kwargs to read function ofxdas.io.febus
. Warn if kwargs not passed.Example:
When we will be sure about this function, we will remove the warnings.