Skip to content
This repository has been archived by the owner on Aug 12, 2024. It is now read-only.

Add DataProvider-Support #14

Open
kevinkendzia opened this issue Jun 24, 2021 · 3 comments
Open

Add DataProvider-Support #14

kevinkendzia opened this issue Jun 24, 2021 · 3 comments
Assignees
@JohannesRabauer
Labels
enhancement New feature or request

Comments

@kevinkendzia
Copy link
Member

It would be nice if the ChipCombobox supported DataProviders through implementing the Vaadin-Interface HasDataProvider
@AB-xdev AB-xdev added the enhancement New feature or request label Jun 24, 2021
@AB-xdev AB-xdev added this to the v2 milestone Jul 7, 2021
@AB-xdev AB-xdev removed this from the v2 milestone Jul 23, 2021
@JohannesRabauer
Copy link
Member

This was also a suggestion in the vaadin directory: https://vaadin.com/directory/component/chip-combobox-for-vaadin/discussions
Please update the question as soon as this issue is implemented.

@JohannesRabauer JohannesRabauer self-assigned this Jan 26, 2023
@JohannesRabauer
Copy link
Member

The Methode of the interface has a deprecated implementation in com.vaadin.flow.component.combobox.ComboBox<T> does not implement HasDataProvider<T> (anymore?). ComboBox still has the methode #setDataProvider, but it is deprecated. That's why we shouldn't implement this interface, but instead implement HasDataView<T, String, ComboBoxDataView<T>>. This interface is implemented by ComboBox.

@JohannesRabauer JohannesRabauer linked a pull request Jan 26, 2023 that will close this issue
14 add dataprovider support #138
Closed
@JohannesRabauer
Copy link
Member

Have to wait for #16 because #138 is based on a withdrawn pull request.

@JohannesRabauer JohannesRabauer mentioned this issue Mar 1, 2023
Closed
@AB-xdev AB-xdev assigned JohannesRabauer and unassigned AB-xdev Mar 14, 2023
xdev-gh-bot pushed a commit that referenced this issue Jan 11, 2024
@AB-xdev
Merge pull request #14 from xdev-software/dependabot/github_actions/a…
cccbc91 
…ctions/upload-artifact-4

Bump actions/upload-artifact from 3 to 4
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JohannesRabauer JohannesRabauer

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

14 add dataprovider support xdev-software/vaadin-chip-combobox
3 participants
@JohannesRabauer @AB-xdev @kevinkendzia