Fix linter errors

Author: xdoubleu

examples/simplehttp/main_test.go

@@ -34,7 +34,12 @@ func TestHealth(t *testing.T) {
 
 	app := NewApp(logger, cfg, db)
 
-	tReq := test.CreateRequestTester(app.Routes(), test.JsonContentType, http.MethodGet, "/health")
+	tReq := test.CreateRequestTester(
+		app.Routes(),
+		test.JSONContentType,
+		http.MethodGet,
+		"/health",
+	)
 	rs := tReq.Do(t)
 
 	var rsData Health

pkg/communication/http/form.go

@@ -7,12 +7,11 @@ import (
 	"github.com/gorilla/schema"
 )
 
-//nolint:gochecknoglobals //ok
-var decoder = schema.NewDecoder()
-var encoder = schema.NewEncoder()
-
+// WriteForm writes the provided data to [url.Values].
 func WriteForm(src any) (url.Values, error) {
 	values := url.Values{}
+
+	encoder := schema.NewEncoder()
 	err := encoder.Encode(src, values)
 	if err != nil {
 		return nil, err
@@ -21,12 +20,14 @@ func WriteForm(src any) (url.Values, error) {
 	return values, nil
 }
 
+// ReadForm reads url-encoded form data and assigns this to dst.
 func ReadForm(r *http.Request, dst any) error {
 	err := r.ParseForm()
 	if err != nil {
 		return err
 	}
 
+	decoder := schema.NewDecoder()
 	err = decoder.Decode(dst, r.PostForm)
 	if err != nil {
 		return err

pkg/test/api_helpers_test.go

@@ -33,7 +33,7 @@ func paginatedEndpointHandler(w http.ResponseWriter, r *http.Request) {
 func TestPaginatedEndpointTester(t *testing.T) {
 	tReq := test.CreateRequestTester(
 		http.HandlerFunc(paginatedEndpointHandler),
-		test.JsonContentType,
+		test.JSONContentType,
 		http.MethodGet,
 		"",
 	)

pkg/test/matrix_tester_test.go

@@ -66,7 +66,7 @@ func matrixTestHandler(w http.ResponseWriter, r *http.Request) {
 func TestMatrixTester(t *testing.T) {
 	baseRequest := test.CreateRequestTester(
 		http.HandlerFunc(matrixTestHandler),
-		test.JsonContentType,
+		test.JSONContentType,
 		http.MethodGet,
 		"",
 	)

pkg/test/request.go

@@ -15,11 +15,16 @@ import (
 	httptools "github.com/XDoubleU/essentia/pkg/communication/http"
 )
 
+// ContentType is used to set the "Content-Type" header of requests.
+// This also has an influence on the encoding of your data.
 type ContentType = int
 
 const (
-	JsonContentType ContentType = iota
-	FormContentType             = iota
+	// JSONContentType sets the "Content-Type" header to "application/json".
+	JSONContentType ContentType = iota
+	// FormContentType sets the "Content-Type" header to
+	// "application/x-www-form-urlencoded".
+	FormContentType = iota
 )
 
 // A RequestTester is used to test a certain HTTP request.
@@ -103,7 +108,7 @@ func (tReq RequestTester) Do(t *testing.T) *http.Response {
 
 	if tReq.data != nil {
 		switch tReq.contentType {
-		case JsonContentType:
+		case JSONContentType:
 			contentType = "application/json"
 
 			var body []byte
@@ -168,12 +173,13 @@ func (tReq RequestTester) Do(t *testing.T) *http.Response {
 // Copy creates a copy of a [RequestTester] in order to easily test similar requests.
 func (tReq RequestTester) Copy() RequestTester {
 	return RequestTester{
-		handler: tReq.handler,
-		ts:      tReq.ts,
-		method:  tReq.method,
-		path:    tReq.path,
-		data:    tReq.data,
-		query:   tReq.query,
-		cookies: tReq.cookies,
+		handler:     tReq.handler,
+		ts:          tReq.ts,
+		contentType: tReq.contentType,
+		method:      tReq.method,
+		path:        tReq.path,
+		data:        tReq.data,
+		query:       tReq.query,
+		cookies:     tReq.cookies,
 	}
 }

pkg/test/request_test.go

@@ -15,7 +15,7 @@ type Test struct {
 	Key string
 }
 
-func testHandlerJson(w http.ResponseWriter, r *http.Request) {
+func testHandlerJSON(w http.ResponseWriter, r *http.Request) {
 	cookie, err := r.Cookie("cookiename")
 	if err != nil || cookie.Value != "value" {
 		httptools.ServerErrorResponse(w, r, err)
@@ -41,8 +41,8 @@ func TestRequestTesterJson(t *testing.T) {
 	}
 
 	tReq := test.CreateRequestTester(
-		http.HandlerFunc(testHandlerJson),
-		test.JsonContentType,
+		http.HandlerFunc(testHandlerJSON),
+		test.JSONContentType,
 		http.MethodPost,
 		"/test/%d",
 		1,
@@ -110,9 +110,15 @@ func TestRequestTesterTestServer(t *testing.T) {
 		Key: "data",
 	}
 
-	ts := httptest.NewServer(http.HandlerFunc(testHandlerJson))
+	ts := httptest.NewServer(http.HandlerFunc(testHandlerJSON))
 
-	tReq := test.CreateRequestTester(nil, test.JsonContentType, http.MethodGet, "/test/%d", 1)
+	tReq := test.CreateRequestTester(
+		nil,
+		test.JSONContentType,
+		http.MethodGet,
+		"/test/%d",
+		1,
+	)
 	tReq.AddCookie(&http.Cookie{Name: "cookiename", Value: "value"})
 	tReq.SetData(reqData)
 	tReq.SetTestServer(ts)
@@ -128,7 +134,7 @@ func TestRequestTesterTestServer(t *testing.T) {
 }
 
 func TestRequestTesterNoTestServerOrHandler(t *testing.T) {
-	tReq := test.CreateRequestTester(nil, test.JsonContentType, http.MethodGet, "")
+	tReq := test.CreateRequestTester(nil, test.JSONContentType, http.MethodGet, "")
 
 	assert.PanicsWithValue(
 		t,